samba.git/libgpo, branch master

libgpo: Use ISDOT/ISDOTDOT

2026-01-20T11:53:34+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Anoop C S

libsmb: Remove "source3/libsmb/libsmb.h"

2025-06-16T15:05:32+00:00

libsmb.h added ads_status.h and cli_smb2_fnum.h. Only few users need
either.

Signed-off-by: Volker Lendecke 
Reviewed-by: Ralph Boehme

libgpo:admx:: s/the the\b/the/

2024-11-12T09:21:53+00:00

Signed-off-by: Douglas Bagnall 
Reviewed-by: Volker Lendecke 

Autobuild-User(master): Volker Lendecke 
Autobuild-Date(master): Tue Nov 12 09:21:53 UTC 2024 on atb-devel-224

libgpo: Initialize struct security_ace array

2024-07-16T11:41:33+00:00

"Error: UNINIT (CWE-457):
samba-4.20.0rc2/libgpo/gpo_reg.c:708: var_decl: Declaring variable ""ace"" without initializer.
samba-4.20.0rc2/libgpo/gpo_reg.c:755: uninit_use_in_call: Using uninitialized value ""*ace"". Field ""ace->object"" is uninitialized when calling ""make_sec_acl"".
  753|   		     mask, inherit_flags);
  754|
  755|-> 	theacl = make_sec_acl(mem_ctx, NT4_ACL_REVISION, 6, ace);
  756|   	W_ERROR_HAVE_NO_MEMORY(theacl);
  757|"

Signed-off-by: Andreas Schneider 
Reviewed-by: Guenther Deschner

libgpo/pygpo: make use of ads_connect_{creds,machine}()

2024-05-14T10:18:31+00:00

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andreas Schneider

lib: Give lib/util/util_file.c its own header file

2024-04-16T23:51:45+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Martin Schwenke

libgpo: Do not segfault if we don't have a valid security descriptor

2024-03-06T15:44:19+00:00

Program received signal SIGSEGV, Segmentation fault.
ndr_push_security_descriptor (ndr=ndr@entry=0x555555bf41b0, ndr_flags=ndr_flags@entry=768, r=r@entry=0x0) at librpc/gen_ndr/ndr_security.c:713
713				NDR_CHECK(ndr_push_security_descriptor_revision(ndr, NDR_SCALARS, r->revision));

Thread 1 (Thread 0x7ffff7ece740 (LWP 21460) "python3"):
 #0  ndr_push_security_descriptor (ndr=ndr@entry=0x555555bf41b0, ndr_flags=ndr_flags@entry=768, r=r@entry=0x0) at librpc/gen_ndr/ndr_security.c:713
        _flags_save_STRUCT = 0
        _status = 
        _status = 
        _status = 
        _status = 
        _status = 
        _status = 
        _status = 
        _status = 
        _status = 
        _status = 
        _status = 
        _status = 
        _status = 
        _status = 
        _status = 
        _status = 
        _status = 
        _status = 
        _status = 
        _status = 
        __FUNCTION__ = "ndr_push_security_descriptor"
 #1  0x00007ffff617237f in ndr_push_struct_blob (blob=blob@entry=0x7fffffffdb20, mem_ctx=0x555555aa3bd0, p=0x0, fn=0x7ffff6074ad0 , fn@entry=0x7ffff60706c8 ) at ../../librpc/ndr/ndr.c:1438
        _status = 
        ndr = 0x555555bf41b0
 #2  0x00007ffff607cccf in marshall_sec_desc (mem_ctx=, secdesc=, data=data@entry=0x7fffffffdb80, len=len@entry=0x7fffffffdb78) at ../../libcli/security/secdesc.c:241
        blob = {data = 0x7fffffffdb40 "`\333\377\377\377\177", length = 140737352374299}
        ndr_err = 
        __FUNCTION__ = "marshall_sec_desc"
 #3  0x00007ffff29edd94 in GPO_marshall_get_sec_desc_buf (self=, args=, kwds=) at ../../libgpo/pygpo.c:119
        gpo_ptr = 
        status = 
        data = 0x0
        len = 0

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15599

Signed-off-by: Andreas Schneider 
Reviewed-by: David Mulder 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Wed Mar  6 15:44:19 UTC 2024 on atb-devel-224

libgpo: Fix trailing spaces in pygpo.c

2024-03-06T14:38:37+00:00

Reviewed-by: David Mulder

libgpo: fix wrong lineending in admx files

2023-11-27T01:12:40+00:00

When changing or reviewing admx file patches, make sure, that those files are
dos fileformat and they need to have the magic ^M at the end of each line ...

Signed-off-by: Bjoern Jacke 
Reviewed-by: Andrew Bartlett

Use python.h from libreplace

2023-11-20T15:37:33+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15513

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett