samba.git/librpc, branch master

ndr:dns_utils.h: add header guards

2026-04-16T01:57:42+00:00

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andreas Schneider 

Autobuild-User(master): Douglas Bagnall 
Autobuild-Date(master): Thu Apr 16 01:57:42 UTC 2026 on atb-devel-224

ndr/util push_dns_string: avoid unnecessary tallocs

2026-04-16T00:54:44+00:00

We know the components are all less than 64 bytes long.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14378

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andreas Schneider

ndr:dns: introduce and use MAX_COMP_LEN

2026-04-16T00:54:44+00:00

it means 63 or 0x3f, and is the maximum length of a DNS/NBT component.

We also simplify an error message that was fond of long hex
representations of small numbers.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14378

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andreas Schneider

ndr: pull_dns_string: don't allow dots or '\0' in labels

2026-04-16T00:54:44+00:00

We use a copy function that returns false if the copied string
contains the bad characters, and true otherwise.

As a special case, we allow a '.' as the last character, because an
NBT name with a trailing dot is sometimes used as a username, and we
need to match these exactly, even though the dotless form is
semantically the same (per RFC).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14378

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andreas Schneider

librpc/tests: Initialize name _test_ndr_pull_dns_string_list

2026-04-16T00:54:43+00:00

When ndr_pull_struct_blob fails (which it will for labels containing
dots, now rejected by the new dns_component_copy check), name remains
uninitialized and the subsequent push call dereference it.

Signed-off-by: Andreas Schneider 
Reviewed-by: Douglas Bagnall

ndr: pull_dns_string: check length, use buffers/memcpy

2026-04-16T00:54:43+00:00

RFC 1035 says the maximum length for a DNS name is 255 characters, and
one of the factors that allowed CVE-2020-10745 is that Samba did not
enforce that directly, enabling names around 8k long.

We fix that by keeping track of the name length. It is easier and more
efficient to use a 64 byte buffer for the components, and this will
help us to introduce further hardening in the next commit.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14378

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andreas Schneider

ndr: pull_dns_string: drop nbt/dns mem_ctx difference

2026-04-16T00:54:43+00:00

Until now NBT and DNS have used talloc contexts of different lifetimes
to allocate component strings. The actual talloc context doesn't
really matter -- these strings are immediately copied and can be freed
straight after. So that is what we do.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14378

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andreas Schneider

ndr/nbt: use ndr_dns_utils/ndr_pull_dns_string_list

2026-04-16T00:54:43+00:00

To retain exactly the same behaviour with regard to memory contexts
and error messages, we add an is_nbt flag.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14378

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andreas Schneider

ndr/dns: shift pull_dns_string to ndr_dns_util.c

2026-04-16T00:54:43+00:00

This will allow NBT to use the same function (after modifications in
the next commit).

This is post CVE-2020-10745 hardening and optimisation.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14378

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andreas Schneider

s3/rpc_server: Add worker status smbcontrol message support

2026-04-14T12:12:07+00:00

Add information about the number of connections a rpc_worker
process is handling and when each connection was initiated.

command
  smbcontrol 55063 rpc-dump-worker-status

will output data like below:

  rpcd_spoolss pid 55063:
      num connections = 2
      num_association_groups = 2
      last client connection 2026/03/18 06:51:04.482192
      last client disconnection 2026/03/18 06:51:00.304951
   active connections:
      [1] endpoint=ncacn_np:[\pipe\spoolss] client addr=192.168.32.175 server=priu0002 connected at 2026/03/18 06:51:04.482192
      [2] endpoint=ncacn_np:[\pipe\spoolss] client addr=192.168.33.232 server=priu0002 connected at 2026/03/18 06:47:08.466157

Signed-off-by: Noel Power 
Reviewed-by: Volker Lendecke 

Autobuild-User(master): Noel Power 
Autobuild-Date(master): Tue Apr 14 12:12:07 UTC 2026 on atb-devel-224