samba.git/pidl/lib, branch talloc-2.3.3

pidl: Avoid leaving array_size NDR tokens around

2021-06-02T03:56:36+00:00

In many cases these can and should be consumed as soon as
they are used.

This is not a complete fix, we don't clean up the array_size
token after using it split between an NDR_SCALARS and
an NDR_BUFFERS pass, but it is much better than it was
and helps the winbind case with a large number of groups
(eg 100,000) as otherwise we hit the 65535 NDR token limit.

(This is an arbitary Samba-only limit to avoid DoS conditions)

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14710

Signed-off-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall

pidl: Avoid leaving array_length NDR tokens around

2021-06-02T03:56:36+00:00

In many cases these can and should be consumed as soon as
they are used.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14710

Signed-off-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall

libndr: Return error code from ndr_token_peek()

2021-06-02T03:56:36+00:00

This makes it safer to change our code to remove tokens after use
if failing to obtain a token would result in an error.

This means changing ndr_get_array_size() and ndr_get_array_length()
to also return an error code.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14710

Signed-off-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall

pidl: Handle assigning to an inline array from Python

2021-05-28T09:50:02+00:00

When obtaining a reference to items in an assigned-from list, ensure
that we do not try to use the first element of the inline array as a
talloc context, but instead use the talloc context associated with the
Python object.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14065

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Andreas Schneider 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Fri May 28 09:50:02 UTC 2021 on sn-devel-184

pidl: set the per-request memory context in the pidl generator

2021-03-31T11:11:31+00:00

The talloc memory context referenced by the pipe_struct mem_ctx member is used
as talloc parent for RPC response data by the RPC service implementations.

In Samba versions up to 4.10 all talloc children of p->mem_ctx were freed after
a RPC response was delivered by calling talloc_free_children(p->mem_ctx). Commit
60fa8e255254d38e9443bf96f2c0f31430be6ab8 removed this call which resulted in all
memory allocations on this context not getting released, which can consume
significant memory in long running RPC connections.

Instead of putting the talloc_free_children(p->mem_ctx) back, just use the
mem_ctx argument of the ${pipename}_op_dispatch_internal() function which is a
dcesrv_call_state object created by dcesrv_process_ncacn_packet() and released
by the RPC server when the RPC request processing is finished.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14675
CI: https://gitlab.com/samba-team/samba/-/merge_requests/1861

Signed-off-by: Ralph Boehme 
Reviewed-by: Volker Lendecke

pidl: use unused attribute only if supported by feature macro

2020-11-10T06:53:43+00:00

Signed-off-by: Bjoern Jacke 
Reviewed-by: Andrew Bartlett

pypidl: check the result of py_dcerpc_ndr_pointer_deref()

2020-07-06T12:30:33+00:00

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andreas Schneider 
Reviewed-by: Ralph Boehme

s3: rpc_server: Remove dead code

2020-05-24T23:55:37+00:00

Signed-off-by: Samuel Cabrero 
Reviewed-by: Andrew Bartlett

s3: rpc_server: Drop s3 rpc handles implementation

2020-05-24T23:55:37+00:00

Signed-off-by: Samuel Cabrero 
Reviewed-by: Andrew Bartlett

pidl: Set dce_call in pipes_struct before dispatching call

2020-05-24T23:55:37+00:00

Signed-off-by: Samuel Cabrero 
Reviewed-by: Andrew Bartlett