samba.git/pidl/lib, branch talloc-2.4.2 Unnamed repository; edit this file 'description' to name the repository. librpc: Change type of ‘u16string’ from ‘const uint16_t *’ to ‘const unsigned char *’ 2023-12-21T23:48:46+00:00 Joseph Sutton josephsutton@catalyst.net.nz 2023-12-20T22:51:19+00:00 346844b730b06fe5ad53dc93fc0f4d4470794cb5 A u16string is supposed to contain UTF‐16 code units, but ndr_pull_u16string() and ndr_push_u16string() fail to correctly ensure this on big‐endian systems. Code that relies on the u16string array containing correct values will then fail. Fix ndr_pull_u16string() and ndr_push_u16string() to work on big‐endian systems, ensuring that other code can use these strings without having to worry about first encoding them to little‐endian. Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
A u16string is supposed to contain UTF‐16 code units, but
ndr_pull_u16string() and ndr_push_u16string() fail to correctly ensure
this on big‐endian systems. Code that relies on the u16string array
containing correct values will then fail.

Fix ndr_pull_u16string() and ndr_push_u16string() to work on big‐endian
systems, ensuring that other code can use these strings without having
to worry about first encoding them to little‐endian.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
pidl: Make sure to cast whole expressions 2023-11-30T00:02:33+00:00 Joseph Sutton josephsutton@catalyst.net.nz 2023-11-26T23:58:05+00:00 e3f81fa71ee08f78b43f5b1817eb44d1c59bd40e $cvar could be an expression such as ‘1 << 10’. In such cases this cast presumably was intended to apply to the entire expression, not just to the ‘1’. Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
$cvar could be an expression such as ‘1 << 10’. In such cases this cast
presumably was intended to apply to the entire expression, not just to
the ‘1’.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
pidl: Fix subscripts of dereferenced arrays 2023-11-30T00:02:33+00:00 Joseph Sutton josephsutton@catalyst.net.nz 2023-11-22T02:54:50+00:00 3da132a8dfb9671075b38d378a3df2b58fc09931 Pidl will generate code like the following: py_out_2 = PyLong_FromLong((uint16_t)*r->out.out[out_cntr_2]); As the array subscripting operator has a higher precedence than the indirection (derference) operator, the argument will be evaluated as (uint16_t)*(r->out.out[out_cntr_2]), which is wrong. Fix Pidl to generate the following code instead: py_out_2 = PyLong_FromLong((uint16_t)(*r->out.out)[out_cntr_2]); Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
Pidl will generate code like the following:

py_out_2 = PyLong_FromLong((uint16_t)*r->out.out[out_cntr_2]);

As the array subscripting operator has a higher precedence than the
indirection (derference) operator, the argument will be evaluated as
(uint16_t)*(r->out.out[out_cntr_2]), which is wrong.

Fix Pidl to generate the following code instead:

py_out_2 = PyLong_FromLong((uint16_t)(*r->out.out)[out_cntr_2]);

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
pidl: Remove unneeded casts 2023-11-30T00:02:33+00:00 Joseph Sutton josephsutton@catalyst.net.nz 2023-11-22T02:24:55+00:00 dbc9c9bd12808634a87a4b90058ffecede1614cf _pytalloc_get_ptr() returns ‘void *’. Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
_pytalloc_get_ptr() returns ‘void *’.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
pidl: Add new ‘u16string’ type 2023-11-20T21:50:32+00:00 Joseph Sutton josephsutton@catalyst.net.nz 2023-11-19T21:07:22+00:00 f94b981e8641a6b18f72a50b6596e9275bb034e4 This type represents a UTF‐16–encoded string. These strings are kept UTF‐16–encoded rather than converted to the Unix charset to be stored in memory; this avoids issues regarding NULL termination and conversion between character sets. We want to be able to handle strings that are not valid UTF‐16. Not bumping the NDR ABI version, because there hasn’t been an NDR release since commit c4f281e9ae36c225b6003e0fa1cb8fb2e67bf543. Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
This type represents a UTF‐16–encoded string. These strings are kept
UTF‐16–encoded rather than converted to the Unix charset to be stored in
memory; this avoids issues regarding NULL termination and conversion
between character sets. We want to be able to handle strings that are
not valid UTF‐16.

Not bumping the NDR ABI version, because there hasn’t been an NDR
release since commit c4f281e9ae36c225b6003e0fa1cb8fb2e67bf543.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
pidl: Add a helper function to determine whether a type is a string type 2023-11-20T21:50:32+00:00 Joseph Sutton josephsutton@catalyst.net.nz 2023-11-19T21:03:59+00:00 436814572d435f6de4f3b390f07d0124fc4a7105 Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Use python.h from libreplace 2023-11-20T15:37:33+00:00 Andreas Schneider asn@samba.org 2023-11-09T10:35:56+00:00 9621a3d7a6949aa833425884cd22379387738cfa BUG: https://bugzilla.samba.org/show_bug.cgi?id=15513 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15513

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 pidl: include scompat headers and servers in s3 server template 2023-11-17T00:39:18+00:00 Günther Deschner gd@samba.org 2023-11-07T00:19:16+00:00 82f021d43de1643d06332e152fcaf3e07e51cd1b Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Samuel Cabrero <scabrero@samba.org> Autobuild-User(master): Günther Deschner <gd@samba.org> Autobuild-Date(master): Fri Nov 17 00:39:18 UTC 2023 on atb-devel-224 
Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Samuel Cabrero <scabrero@samba.org>

Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Fri Nov 17 00:39:18 UTC 2023 on atb-devel-224
pidl: Don’t overwrite exception set by PyUnicode_AsEncodedString() 2023-11-16T05:18:36+00:00 Joseph Sutton josephsutton@catalyst.net.nz 2023-11-14T23:10:36+00:00 7a9ad610226dfbdb5e645e6fe98fd266a960e2d1 Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
pidl: Remove trailing whitespace 2023-11-16T05:18:36+00:00 Joseph Sutton josephsutton@catalyst.net.nz 2023-11-09T01:08:19+00:00 ddb98e7d611f7c3160af4ea54bb6cf6bdf1ad0a3 Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>