samba.git/python/samba/dbchecker.py, branch talloc-2.1.14

dbchecker: Fixing up incorrect DNs wasn't working

2018-07-03T03:24:13+00:00

dbcheck would fail to fix up attributes where the extended DN's GUID is
correct, but the DN itself is incorrect. The code failed attempting to
remove the old/incorrect DN, e.g.

 NOTE: old (due to rename or delete) DN string component for
 objectCategory in object CN=alice,CN=Users,DC=samba,DC=example,DC=com -
 ;
   CN=Person,CN=Schema,CN=Configuration,DC=samba,DC=bad,DC=com
 Change DN to ;
   CN=Person,CN=Schema,CN=Configuration,DC=samba,DC=example,DC=com?
 [y/N/all/none] y
 Failed to fix old DN string on attribute objectCategory : (16,
 "attribute 'objectCategory': no matching attribute value while deleting
 attribute on 'CN=alice,CN=Users,DC=samba,DC=example,DC=com'")

The problem was the LDB message specified the value to delete with its
full DN, including the GUID. The LDB code then helpfully corrected this
value on the way through, so that the DN got updated to reflect the
correct DN (i.e. 'DC=example,DC=com') of the object matching that GUID,
rather than the incorrect DN (i.e. 'DC=bad,DC=com') that we were trying
to remove. Because the requested value and the existing DB value didn't
match, the operation failed.

We can avoid this problem by passing down just the DN (not the extended
DN) of the value we want to delete. Without the GUID portion of the DN,
the LDB code will no longer try to correct it on the way through, and
the dbcheck operation will succeed.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13495

Signed-off-by: Tim Beale 
Signed-off-by: Andrew Bartlett 
Reviewed-by: Gary Lockyer 
Pair-programmed-with: Andrew Bartlett

dbcheck: Use symbolic control name for DSDB_CONTROL_DBCHECK_FIX_DUPLICATE_LINKS

2018-07-03T03:24:13+00:00

While we do not wish to encourage use of this control, manually typed OIDs are
even more trouble, so pass out via pydsdb.

Signed-off-by: Andrew Bartlett 
Reviewed-by: Gary Lockyer

python: Bulk conversion callers of ldb.Dn second param

2018-04-30T13:43:19+00:00

Convert second param passed to ldb.Dn to be unicode so py2 & py3 code
will work

Signed-off-by: Noel Power 
Reviewed-by: Alexander Bokovoy

python/samba: bulk conversion of caller to dsdb_Dn 2nd param.

2018-04-30T13:43:19+00:00

Convert second param to dsdb_Dn to be unicode so py2 & py3 code
will work

Signed-off-by: Noel Power 
Reviewed-by: Alexander Bokovoy

samba python libs: convert print func to be py2/py3 compatible

2018-03-23T06:28:23+00:00

Signed-off-by: Noel Power 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall

samba python libs: convert 'except X, (tuple)' to 'except X as e'

2018-02-28T22:01:40+00:00

In addition to converting the except line another line is also added
for each except to extract the tuple contents.

Signed-off-by: Noel Power 
Reviewed-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

samba python libs: convert 'except X, e' to 'except X as e'

2018-02-14T23:18:30+00:00

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

dbcheck: skip find_missing_forward_links_from_backlinks() if the db has the sortedLinks feature

2018-02-05T17:32:51+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Ralph Boehme 

Autobuild-User(master): Stefan Metzmacher 
Autobuild-Date(master): Mon Feb  5 18:32:51 CET 2018 on sn-devel-144

dbcheck: add support for restoring missing forward links

2018-02-05T12:49:13+00:00

This recovers broken databases with duplicate and missing
forward links.

See commit a25c99c9f1fd1814c56c21848c748cd0e038eed7 for
the fix that prevents to problem from happening.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228

Pair-Programmed-With: Stefan Metzmacher 

Signed-off-by: Ralph Boehme 
Signed-off-by: Stefan Metzmacher

dbcheck: add find_missing_forward_links_from_backlinks()

2018-02-05T12:49:13+00:00

find_missing_forward_links_from_backlinks() finds and returns missing forward-links by
searching all for all objects that link to the object in the backlink attribute.

This will be used in the next commit to restore forward links in a corrupted
forward link attribute by passing the missing backling objects to
err_recover_forward_links().

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228

Pair-Programmed-With: Stefan Metzmacher 

Signed-off-by: Ralph Boehme 
Signed-off-by: Stefan Metzmacher