samba.git/python/samba/dbchecker.py, branch talloc-2.2.0

dbcheck: don't check expired tombstone objects by default anymore

2019-03-14T03:12:27+00:00

These will be removed anyway and any change on them risks to
be an originating update that causes replication problems.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13816

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Thu Mar 14 03:12:27 UTC 2019 on sn-devel-144

dbcheck: detect the change after deletion bug

2019-03-14T02:12:20+00:00

Old versions of 'samba-tool dbcheck' could reanimate
deleted objects, when running at the same time as the
tombstone garbage collection.

When the (deleted) parent of a deleted object
(with the DISALLOW_MOVE_ON_DELETE bit in systemFlags),
is removed before the object itself, dbcheck moved
it in the LostAndFound[Config] subtree of the partition
as an originating change. That means that the object
will be in tombstone state again for 180 days on the local
DC. And other DCs fail to replicate the object as
it's already removed completely there and the replication
only gives the name and lastKnownParent attributes, because
all other attributes should already be known to the other DC.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13816

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andrew Bartlett

dbcheck: add find_repl_attid() helper function

2019-03-14T02:12:20+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13816

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andrew Bartlett

dbcheck: don't remove dangling one-way links on already deleted objects

2019-03-14T02:12:20+00:00

This would typically happen when the garbage collection
removed a parent object before a child object (both with
the DISALLOW_MOVE_ON_DELETE bit set in systemFlags),
while dbcheck is running at the same time as the garbage collection.
In this case the lastKnownParent attributes points a non existing
object.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13816

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andrew Bartlett

dbcheck: don't move already deleted objects to LostAndFound

2019-03-14T02:12:20+00:00

This would typically happen when the garbage collection
removed a parent object before a child object (both with
the DISALLOW_MOVE_ON_DELETE bit set in systemFlags),
while dbcheck is running at the same time as the garbage collection.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13816

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andrew Bartlett

dbcheck: do isDeleted, systemFlags and replPropertyMetaData detection first

2019-03-14T02:12:20+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13816

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andrew Bartlett

dbcheck: use DSDB_CONTROL_DBCHECK_FIX_LINK_DN_NAME when renaming deleted objects

2019-03-14T02:12:19+00:00

We should never do originating updates on deleted objects.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13816

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andrew Bartlett

dbcheck: skip reverse member link checks when cli option specified

2019-02-21T03:09:19+00:00

currently dbcheck cmd tooks about 1 day to finish on a 100k user database.
We can skip member reverse link checks to speed it up dramatically.
A new cli option is added to enable the skipping.

Signed-off-by: Joe Guo 
Reviewed-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

Fix spelling mistakes

2018-11-30T02:35:13+00:00

Signed-off-by: Olly Betts 
Reviewed-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

python dbcheck: don't use mutable default args

2018-11-02T02:48:52+00:00

In this code

def f(a, b=[]):
    b.append(a)
    return b

all single argument calls to f() will affect the same copy of b.

In the controls case, controls=None has the same effect as
controls=[].

Signed-off-by: Douglas Bagnall 
Reviewed-by: Noel Power