samba.git/python/samba/dbchecker.py, branch talloc-2.3.2

python: Move dsdb_Dn to samdb

2020-10-02T13:29:35+00:00

The import dsdb needed for dsdb_Dn causes import
errors when trying to import get_bytes/get_string
in some places.

Signed-off-by: David Mulder 
Reviewed-by: Douglas Bagnall

dbcheck: Allow a dangling forward link outside our known NCs

2020-07-29T03:19:02+00:00

If we do not have the NC of the target object we can not be really sure
that the object is redundent and so we want to keep it for now
and not (as happened until now) break the dbcheck run made during the
replication stage of a "samba-tool domain backup rename".

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14450

Signed-off-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall

dbcheck: omit unused argument in err_wrong_default_sd

2020-07-17T07:17:39+00:00

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andreas Schneider 
Reviewed-by: David Mulder

python/samba/dbchecker.py: typo fixes

2019-10-31T00:43:36+00:00

Signed-off-by: Bjoern Jacke 
Reviewed-by: Martin Schwenke

dbcheck: fallback to the default tombstoneLifetime of 180 days

2019-05-28T08:32:09+00:00

If a domain was provisioned by Windows 2000 this value is missing in the
database.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13967

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Ralph Boehme 

Autobuild-User(master): Stefan Metzmacher 
Autobuild-Date(master): Tue May 28 08:32:10 UTC 2019 on sn-devel-184

dbcheck: fix the err_empty_attribute() check

2019-03-21T18:15:20+00:00

ldb.bytes('') == '' is never True in python3,
we nee ldb.bytes('') == b'' in order to
check that on attribute has an empty value,
that seems to work for python2 and python3.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13843

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Noel Power 

Autobuild-User(master): Stefan Metzmacher 
Autobuild-Date(master): Thu Mar 21 18:15:20 UTC 2019 on sn-devel-144

dbcheck: use the str() value of the "name" attribute

2019-03-21T16:42:19+00:00

We do the same with the rdn attribute value
and we need the same logic on both in order to
check they are the same.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13816

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Noel Power

dbcheck: don't check expired tombstone objects by default anymore

2019-03-14T03:12:27+00:00

These will be removed anyway and any change on them risks to
be an originating update that causes replication problems.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13816

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Thu Mar 14 03:12:27 UTC 2019 on sn-devel-144

dbcheck: detect the change after deletion bug

2019-03-14T02:12:20+00:00

Old versions of 'samba-tool dbcheck' could reanimate
deleted objects, when running at the same time as the
tombstone garbage collection.

When the (deleted) parent of a deleted object
(with the DISALLOW_MOVE_ON_DELETE bit in systemFlags),
is removed before the object itself, dbcheck moved
it in the LostAndFound[Config] subtree of the partition
as an originating change. That means that the object
will be in tombstone state again for 180 days on the local
DC. And other DCs fail to replicate the object as
it's already removed completely there and the replication
only gives the name and lastKnownParent attributes, because
all other attributes should already be known to the other DC.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13816

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andrew Bartlett

dbcheck: add find_repl_attid() helper function

2019-03-14T02:12:20+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13816

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andrew Bartlett