samba.git/python/samba/dbchecker.py, branch talloc-2.4.0

dbcheck: Fix truncation of warning messages

2022-10-05T04:23:33+00:00

We are stripping off one too many characters.

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

py/dbcheck: improve 'please --fix' message

2022-09-19T06:10:36+00:00

The dbcheck module is used in places other than samba-tool (backup,
provision) where the old 'use --fix' message made no sense. Also,
now that we're not necessarily claiming to fix all errors, we say
how many we think we can.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

dbcheck: don't recommend --fix for errors we can't fix

2022-09-19T06:10:36+00:00

and/or won't fix.

I think there are others that should be here.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

dbcheck: do not crash on empty DN

2022-09-19T06:10:36+00:00

we had

$ bin/samba-tool dbcheck -H st/rpc_proxy/private/sam.ldb
Checking 202 objects
ERROR(): uncaught exception - unable to parse dn string
  File "/home/douglasb/src/samba/bin/python/samba/netcmd/__init__.py", line 230, in _run
    return self.run(*args, **kwargs)
  File "/home/douglasb/src/samba/bin/python/samba/netcmd/dbcheck.py", line 173, in run
    error_count = chk.check_database(DN=DN, scope=search_scope,
  File "/home/douglasb/src/samba/bin/python/samba/dbchecker.py", line 255, in check_database
    error_count += self.check_object(object.dn, requested_attrs=attrs)
  File "/home/douglasb/src/samba/bin/python/samba/dbchecker.py", line 2616, in check_object
    expected_dn = ldb.Dn(self.samdb, "RDN=RDN,%s" % (parent_dn))

Now we have:

$ bin/samba-tool dbcheck -H st/rpc_proxy/private/sam.ldb
Checking 202 objects
ERROR: could not handle parent DN '': skipping RDN checks
Please use --fix to fix these errors
Checked 202 objects (1 errors)

which is still not really right, since --fix won't help.

(same with st/s4member/private/sam.ldb).

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

py/dbchecker: dbcheck prints bits of colour if asked

2022-09-19T06:10:36+00:00

Prefixes like ERROR, WARNING, and INFO are given interpretive colours.

This won't change anything until samba-tool decides to ask for colour,
which, who knows, might even be in the next commit.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

python: Remove unnecessary 'pass' statements

2022-05-10T05:19:34+00:00

Signed-off-by: Joseph Sutton 
Reviewed-by: Andreas Schneider

samba-tool: dbcheck search DnsAdmins from wellknown container

2021-06-22T01:14:37+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=9143
Signed-off-by: David Mulder 
Reviewed-by: Andrew Bartlett

dbcheck: formatting

2021-06-11T08:28:28+00:00

Reduce the length of some lines to 79 characters or less.

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Fri Jun 11 08:28:28 UTC 2021 on sn-devel-184

dbcheck: Refactor RID Set check to use free_rid_bounds()

2021-06-11T07:41:38+00:00

This function provides a simpler method of getting the bounds of the
range of RIDs we want to check. We also now check that the low bound is
less than the high bound for both rIDAllocationPool and
rIDPreviousAllocationPool.

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall

dbcheck: check correct RID set attributes when looking for SID conflicts

2021-06-11T07:41:38+00:00

The previous code would only work for the first rid set ever given to a DC
because the names are so misleading.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13632

Signed-off-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall