samba.git/python/samba/dbchecker.py, branch talloc-2.4.2

python: pep257: docstring should use double quotes

2023-12-15T02:54:34+00:00

Signed-off-by: Rob van der Linde 
Reviewed-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

CVE-2018-14628: python:descriptor: let samba-tool dbcheck fix the nTSecurityDescriptor on CN=Deleted Objects containers

2023-10-16T14:39:33+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13595

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andrew Bartlett

CVE-2018-14628: dbchecker: use get_deletedobjects_descriptor for missing deleted objects container

2023-10-16T14:39:33+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13595

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andrew Bartlett

python: Fix code spelling

2023-07-13T05:41:36+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Martin Schwenke

python:samba: Fix code spelling

2023-06-23T14:51:14+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Fri Jun 23 14:51:14 UTC 2023 on atb-devel-224

dbcheck: Fix truncation of warning messages

2022-10-05T04:23:33+00:00

We are stripping off one too many characters.

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

py/dbcheck: improve 'please --fix' message

2022-09-19T06:10:36+00:00

The dbcheck module is used in places other than samba-tool (backup,
provision) where the old 'use --fix' message made no sense. Also,
now that we're not necessarily claiming to fix all errors, we say
how many we think we can.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

dbcheck: don't recommend --fix for errors we can't fix

2022-09-19T06:10:36+00:00

and/or won't fix.

I think there are others that should be here.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

dbcheck: do not crash on empty DN

2022-09-19T06:10:36+00:00

we had

$ bin/samba-tool dbcheck -H st/rpc_proxy/private/sam.ldb
Checking 202 objects
ERROR(): uncaught exception - unable to parse dn string
  File "/home/douglasb/src/samba/bin/python/samba/netcmd/__init__.py", line 230, in _run
    return self.run(*args, **kwargs)
  File "/home/douglasb/src/samba/bin/python/samba/netcmd/dbcheck.py", line 173, in run
    error_count = chk.check_database(DN=DN, scope=search_scope,
  File "/home/douglasb/src/samba/bin/python/samba/dbchecker.py", line 255, in check_database
    error_count += self.check_object(object.dn, requested_attrs=attrs)
  File "/home/douglasb/src/samba/bin/python/samba/dbchecker.py", line 2616, in check_object
    expected_dn = ldb.Dn(self.samdb, "RDN=RDN,%s" % (parent_dn))

Now we have:

$ bin/samba-tool dbcheck -H st/rpc_proxy/private/sam.ldb
Checking 202 objects
ERROR: could not handle parent DN '': skipping RDN checks
Please use --fix to fix these errors
Checked 202 objects (1 errors)

which is still not really right, since --fix won't help.

(same with st/s4member/private/sam.ldb).

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

py/dbchecker: dbcheck prints bits of colour if asked

2022-09-19T06:10:36+00:00

Prefixes like ERROR, WARNING, and INFO are given interpretive colours.

This won't change anything until samba-tool decides to ask for colour,
which, who knows, might even be in the next commit.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett