samba.git/python/samba/drs_utils.py, branch talloc-2.4.2

python: use python3 style super statements

2023-12-15T02:54:34+00:00

Signed-off-by: Rob van der Linde 
Reviewed-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

python: pep257: docstring should use double quotes

2023-12-15T02:54:34+00:00

Signed-off-by: Rob van der Linde 
Reviewed-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

python:samba: Fix code spelling

2023-06-23T14:51:14+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Fri Jun 23 14:51:14 UTC 2023 on atb-devel-224

CVE-2022-37966 selftest: Allow krb5 tests to run against an IP by using the target_hostname binding string

2022-12-13T13:07:29+00:00

This makes it easier to test against a server that is not accessible via DNS.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15237

Signed-off-by: Andrew Bartlett 
Reviewed-by: Stefan Metzmacher

python-drs: Add client-side debug and fallback for GET_ANC

2022-10-04T02:48:37+00:00

Samba 4.5 and earlier will fail to do GET_ANC correctly and will not
replicate non-critical parents of objects with isCriticalSystemObject=TRUE
when DRSUAPI_DRS_CRITICAL_ONLY is set.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15189

Signed-off-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall

libcli:util: Update werror table

2022-06-14T07:21:29+00:00

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Andreas Schneider

drs_utils: remove unused sendRemoveDsServer()

2020-12-09T16:00:39+00:00

The only caller of this was `samba-tool domain demote` which stopped
using it in 2015 with commit f121173cbf46fe64746d73adf40015c43d5c55fc.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Noel Power

drs_utils: Avoid invalid dereference of v8 requests

2018-11-06T06:15:33+00:00

req.more_flags only exists for v10 requests, so we throw an exception if
we try to dereference that field on a v8 (or v5) request. Unfortunately,
we were checking that we support v10 *after* we had tried to access the
more_flags. This patch fixes up the order of the checks.

This may be a problem trying to replicate with an older Windows DC
(pre-2008R2), and was reported on the samba mailing-list at one point:
https://lists.samba.org/archive/samba/2018-June/216541.html

Unfortunately this patch doesn't help the overall situation at all (the
join will fail because we can't resolve the link target and we can't use
GET_TGT). But it now gives you a more meaningful error, i.e.

  ERROR(runtime): uncaught exception - (8639, "Failed to process 'chunk'
    of DRS replicated objects: DOS code 0x000021bf"
instead of:
  ERROR(): uncaught exception -
    'drsuapi.DsGetNCChangesRequest8' object has no attribute 'more_flags'

Signed-off-by: Tim Beale 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Tim Beale 
Autobuild-Date(master): Tue Nov  6 07:15:33 CET 2018 on sn-devel-144

drs_utils: Fix some long lines

2018-11-06T02:39:11+00:00

Tweak the code slightly to avoid some 80+ character lines.

Signed-off-by: Tim Beale 
Reviewed-by: Andrew Bartlett

drs_util: Improve memory usage when joining large DB

2018-10-17T06:56:42+00:00

drs_Replicate.replicate() could consume a large amount of memory when
replicating a large DB. This is not a leak - the memory gets freed when
the function returns (i.e. once the partition is fully replicated).
However, while the partition is in the process of being replicated, it
accumulates memory for each replication chunk it receives. This can have
considerable overhead with 1000s of objects/links in the partition.

This was exhausting memory when joining a VM with 1Gb RAM to a DC with
25K users (average ~15 group memberships per user).

It seems that by storing a reference to something that's on the ctr's
talloc tree, it doesn't free up the memory for each ctr message (until
the function actually returns and req is destroyed).

With 10K users (and average 15 group memberships per user), .replicate()
consumed 211Mb of memory, according to talloc.report_full(). With this
patch, it goes down to just the current ctr message (1-2Mb).

Signed-off-by: Tim Beale 
Reviewed-by: Garming Sam 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Wed Oct 17 08:56:42 CEST 2018 on sn-devel-144