samba.git/python/samba/getopt.py, branch talloc-2.4.2 Unnamed repository; edit this file 'description' to name the repository. python: getopt: HostOptions and other option groups inherit from samba OptionGroup class 2023-10-25T00:31:36+00:00 Rob van der Linde rob@catalyst.net.nz 2023-10-20T01:46:40+00:00 50b8a2de2aadd94386fb0525bfc741867121c929 Signed-off-by: Rob van der Linde <rob@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Wed Oct 25 00:31:37 UTC 2023 on atb-devel-224 
Signed-off-by: Rob van der Linde <rob@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Oct 25 00:31:37 UTC 2023 on atb-devel-224
netcmd: auth policy: add OptionGroup classes for user, service and computer options 2023-10-24T23:31:29+00:00 Rob van der Linde rob@catalyst.net.nz 2023-10-10T10:31:33+00:00 7c389e19212f76aaf9cba8ac8315742c7294e2c8 Signed-off-by: Rob van der Linde <rob@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
Signed-off-by: Rob van der Linde <rob@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
python: getopt: Add HostOptions to avoid need to manually add -H 2023-10-24T23:31:29+00:00 Rob van der Linde rob@catalyst.net.nz 2023-10-06T02:47:43+00:00 e1244ba304a2de598779f9fcf1307244f333ab65 Signed-off-by: Rob van der Linde <rob@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
Signed-off-by: Rob van der Linde <rob@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
python: getopt: implement required flag on options and OptionParser 2023-10-24T23:31:29+00:00 Rob van der Linde rob@catalyst.net.nz 2023-10-05T23:58:46+00:00 e60f3afcc5fca7ec1d8aacfc7abf19009b3d831c Signed-off-by: Rob van der Linde <rob@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
Signed-off-by: Rob van der Linde <rob@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
python: getopt: subclass OptionParser to populate option_class 2023-10-24T23:31:29+00:00 Rob van der Linde rob@catalyst.net.nz 2023-10-19T02:05:56+00:00 837e1d9fdad79ea3a7fdce1232d8dd834f181a63 The option_class needs to be set correctly for OptionGroups that use self.add_option Override OptionParser `__init__` to change the default Option class to the samba one. Signed-off-by: Rob van der Linde <rob@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
The option_class needs to be set correctly for OptionGroups that use self.add_option

Override OptionParser `__init__` to change the default Option class to the samba one.

Signed-off-by: Rob van der Linde <rob@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
python: netcmd: remove OptionError alias to OptionValueError 2023-10-24T23:31:29+00:00 Rob van der Linde rob@catalyst.net.nz 2023-10-05T23:45:35+00:00 fb058e7f2ce3878713af959e8e35d1991bde24ee The other methods in this file already raise optparse.OptionValueError directly, except for two older ones. They are using an alias which changes the name to OptionError, the confusing part about this is that optparse.OptionError actually does exist, so the incorrect alias needs to be removed. Signed-off-by: Rob van der Linde <rob@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
The other methods in this file already raise optparse.OptionValueError
directly, except for two older ones.

They are using an alias which changes the name to OptionError, the
confusing part about this is that optparse.OptionError actually does
exist, so the incorrect alias needs to be removed.

Signed-off-by: Rob van der Linde <rob@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
python: getopt: rename SambaOption to Option 2023-10-24T23:31:29+00:00 Rob van der Linde rob@catalyst.net.nz 2023-10-05T03:26:40+00:00 f77064c8225c79d137e225e962d885e83e113d85 * Nothing uses SambaOption directly, everything imports it through samba.netcmd.Option * Avoid an unnecessary rename on import Signed-off-by: Rob van der Linde <rob@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
 * Nothing uses SambaOption directly, everything imports it through samba.netcmd.Option
 * Avoid an unnecessary rename on import

Signed-off-by: Rob van der Linde <rob@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
python: add docstrings to Validator and ValidationError 2023-10-24T23:31:29+00:00 Rob van der Linde rob@catalyst.net.nz 2023-10-05T01:33:32+00:00 0f93e1d17f8130180e039fcd1230737308a962ce Signed-off-by: Rob van der Linde <rob@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
Signed-off-by: Rob van der Linde <rob@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
python: move Validator base class and ValidationError to getopt 2023-10-24T23:31:29+00:00 Rob van der Linde rob@catalyst.net.nz 2023-10-05T01:30:20+00:00 dc513a82a6a2795b22820146ca583cbe169a7499 It makes more sense for these to exist in the top package, because they are used by SambaOption. validators.py can still exist in netcmd, just not the base class and exception. Signed-off-by: Rob van der Linde <rob@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
It makes more sense for these to exist in the top package, because they are used by SambaOption.

validators.py can still exist in netcmd, just not the base class and exception.

Signed-off-by: Rob van der Linde <rob@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
python: getopt: move validators logic to parent class 2023-10-24T23:31:29+00:00 Rob van der Linde rob@catalyst.net.nz 2023-10-05T01:17:01+00:00 29c9991594f71c4fecc04f3d7701ab93e92ec7ab Signed-off-by: Rob van der Linde <rob@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
Signed-off-by: Rob van der Linde <rob@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>