samba.git/python/samba/gp_parse, branch talloc-2.4.0

python2 reduction: Merge remaining compat code into common

2020-10-02T14:49:36+00:00

The remaining compat code (get_string, get_bytes,
cmp) are useful helper routines which we should
simply merge into common (especially since there
is some duplication here).

Signed-off-by: David Mulder 
Reviewed-by: Douglas Bagnall 

Autobuild-User(master): David Mulder 
Autobuild-Date(master): Fri Oct  2 14:49:36 UTC 2020 on sn-devel-184

python compat: remove ConfigParser

2020-08-24T01:46:30+00:00

Signed-off-by: David Mulder 
Reviewed-by: Andrew Bartlett

python compat: remove text_type

2020-08-11T16:37:35+00:00

Signed-off-by: Douglas Bagnall 
Reviewed-by: Noel Power

python compat: reduce use of 'if PY3:'

2020-08-11T16:37:35+00:00

Signed-off-by: Douglas Bagnall 
Reviewed-by: Noel Power

python compat: remove StringIO

2020-08-11T16:37:35+00:00

Signed-off-by: Douglas Bagnall 
Reviewed-by: Noel Power

python/samba/gp_parse: Fix test errors with python3.8

2020-03-19T20:46:42+00:00

UNEXPECTED(failure): samba.tests.samba_tool.gpo.samba.tests.samba_tool.gpo.GpoCmdTestCase.test_backup_restore_generalize(ad_dc:local)
REASON: Exception: Exception: Traceback (most recent call last):
  File "/tmp/samba-testbase/b28/samba-ad-dc-1/bin/python/samba/tests/samba_tool/gpo.py", line 434, in test_backup_restore_generalize
    self.assertIsNone(has_difference(os.path.join(new_path, 'policy',

This caused because prior to 3.8 minodom.toprettyxml() was sorting the
attribute order, now it preserves the attribute order specified by the user
Signed-off-by: Noel Power 
Reviewed-by: Andrew Bartlett

python: use raw string for regex with escape

2020-02-07T10:37:37+00:00

Python regards 'GPT\.INI$' as a string containing an invalid escape
sequence '\.', which is ignored (i.e. treated as the literal sequence
of those 2 characters), but only after Python has grumbled to itself,
and to you if you enabled DeprecationWarnings.

The proper thing to do here is use r-strings, like r'GPT\.INI$', which
tell Python that all backslashes are literal. Alternatively (as we do
once in this patch), the backslash can itself be escaped ('\\').

There are more problems of this nature in the build scripts.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Noel Power

gp_inf: Read/write files with a UTF-16LE BOM in GptTmpl.inf

2019-07-19T02:20:47+00:00

Regression caused by 16596842a62bec0a9d974c48d64000e3c079254e

[MS-GPSB] 2.2 Message Syntax says that you have to write a BOM which I
didn't do up until this patch. UTF-16 as input encoding was marked much
higher up in the inheritance tree, which got overriden with the Python 3
fixes. I've now marked the encoding much more obviously for this file.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14004

Signed-off-by: Garming Sam 
Reviewed-by: Gary Lockyer 

Autobuild-User(master): Gary Lockyer 
Autobuild-Date(master): Fri Jul 19 02:20:47 UTC 2019 on sn-devel-184

gpo: Parse GPT.INI with Latin-1

2019-03-12T00:42:20+00:00

For some reason the French version of RSAT turns accents into ISO-8859-1.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13806

Signed-off-by: Garming Sam 
Reviewed-by: Andrew Bartlett

py3: io.open takes a numeric buffering argument at index 2

2019-03-12T00:42:20+00:00

It's unsure why this doesn't fail generically, but it fails on my machine sometimes...

Signed-off-by: Garming Sam 
Reviewed-by: Andrew Bartlett