samba.git/python/samba/join.py, branch talloc-2.2.0

join: Throw CommandError instead of Exception for simple errors

2019-01-16T21:11:04+00:00

Throwing an exception here still dumps out the Python stack trace, which
can be a little disconcerting for users.

In this case, the stack trace isn't going to really help at all (the
problem is pretty obvious), and it obscures the useful message
explaining what went wrong.

Throw a CommandError instead, which samba-tool will catch and display
more nicely.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13747

Signed-off-by: Tim Beale 
Reviewed-by: Rowland Penny 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Wed Jan 16 22:11:04 CET 2019 on sn-devel-144

join: Fix TypeError when handling exception

2019-01-16T17:51:27+00:00

When we can't resolve a domain name, we were inadvertently throwing a
TypeError whilst trying to output a helpful message. E.g.

ERROR(): uncaught exception - 'NTSTATUSError' object
does not support indexing

Instead of indexing the object, we want to index the Exception.args so
that we just display the string portion of the exception error.

The same problem is also present for the domain trust commands.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13747

Signed-off-by: Tim Beale 
Reviewed-by: Rowland Penny 
Reviewed-by: Jeremy Allison

PY3: net.change_password & net.set_password take string not bytes

2018-12-10T09:38:21+00:00

Signed-off-by: Noel Power 
Reviewed-by: Andrew Bartlett

python/samba: PY3 Credential.set_password takes string

2018-12-10T09:38:21+00:00

Signed-off-by: Noel Power 
Reviewed-by: Andrew Bartlett

join: Fix join large-DB timeout against Windows

2018-11-06T02:39:11+00:00

The LDAP connection can also timeout when trying to join a Windows DC
with a very large database. However, in this case Windows gives a
slightly different error message (NT_STATUS_CONNECTION_RESET instead of
NT_STATUS_CONNECTION_DISCONNECTED).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13612

Signed-off-by: Tim Beale 
Reviewed-by: Andrew Bartlett

python/join: remove unused imports and variables

2018-11-01T04:08:15+00:00

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

python join: use the sd_utils we imported

2018-11-01T04:08:12+00:00

Signed-off-by: Douglas Bagnall 
Reviewed-by: Noel Power

netcmd: Add backend-store option to domain backup/rename cmds

2018-10-30T23:30:16+00:00

Currently the online/rename backup files always use the default backend
(TDB) and there is no way to change this.

This patch adds the backend-store option to the backup commands so that
you can create a backup with an MDB backend, if needed.

Signed-off-by: Tim Beale 
Reviewed-by: Douglas Bagnall

join: Sanity-check LDB connection before failed join cleanup

2018-10-18T04:15:24+00:00

Joining a large DB can take so long that the LDAP connection times out.
The previous patch fixed the 'happy case' where the join succeeds.
However, if the commit or replication fails (throwing an exception),
then the cleanup code can also fail when it tries to delete objects from
the remote DC. This then gives you an error pointing to
cleanup_old_accounts() rather than what actually went wrong.

This patch adds a sanity-check that if the join fails, that the LDB
connection to the remote DC is still alive, before we start deleting
objects.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13612

Signed-off-by: Tim Beale 
Reviewed-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

join: Avoid searching for more than strictly required during sanity check

2018-10-18T04:15:24+00:00

We check for the default base DN as this does require authentication, but
we do not need to search for more than just that (so use SCOPE_BASE) and
we need no attributes, so ask for none

Signed-off-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall