samba.git/python/samba/join.py, branch talloc-2.3.4

python: Remove unnecessary 'pass' statements

2022-05-10T05:19:34+00:00

Signed-off-by: Joseph Sutton 
Reviewed-by: Andreas Schneider

python/join: improve logging of join_replicate()

2022-03-30T11:13:35+00:00

It's useful to have timestamps to see the
time used for replication and committing.
We also warn the user that the committing stage
may take some time.

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andrew Bartlett

python/join: Check for correct msDS-KrbTgtLink attribute

2021-09-21T23:05:41+00:00

Previously, the wrong case was used when checking for this attribute,
which meant krbtgt accounts were not being cleaned up.

Signed-off-by: Joseph Sutton 
Reviewed-by: Noel Power 
Reviewed-by: Andrew Bartlett

join: provision_fill does not return anything

2021-06-17T04:21:30+00:00

Discovered by Semmle code analysis:
https://lgtm.com/projects/g/samba-team/samba

Signed-off-by: Garming Sam 
Reviewed-by: Douglas Bagnall

python: remove all 'from future import print_function'

2021-04-28T03:43:34+00:00

This made Python 2's print behave like Python 3's print().

In some cases, where we had:

   from __future__ import print_function
   """Intended module documentation..."""

this will have the side effect of making the intended module documentation
work as the actual module documentation (i.e. becoming __doc__), because
it is once again the first statement in the module.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

pydns: rename s/CNameRecord/CNAMERecord/ for consistency

2021-04-08T21:54:35+00:00

Everything else is TXTRecord, SRVRrcord, SOARecord.

Making CNAME the same allows easier lookups.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andreas Schneider

provision: Decrease the length of random machine passwords

2021-04-07T09:18:30+00:00

The current length of 128-255 UTF-16 characters currently causes
generation of crypt() passwords to typically fail. This commit
decreases the length to 120 UTF-16 characters, which is the same as
that used by Windows.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14621

Signed-off-by: Joseph Sutton 
Reviewed-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

py.join: remove unused untested get_naming_master

2021-03-17T18:23:04+00:00

Signed-off-by: Douglas Bagnall 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Wed Mar 17 18:23:04 UTC 2021 on sn-devel-184

python2 reduction: Merge remaining compat code into common

2020-10-02T14:49:36+00:00

The remaining compat code (get_string, get_bytes,
cmp) are useful helper routines which we should
simply merge into common (especially since there
is some duplication here).

Signed-off-by: David Mulder 
Reviewed-by: Douglas Bagnall 

Autobuild-User(master): David Mulder 
Autobuild-Date(master): Fri Oct  2 14:49:36 UTC 2020 on sn-devel-184

python compat: remove text_type

2020-08-11T16:37:35+00:00

Signed-off-by: Douglas Bagnall 
Reviewed-by: Noel Power