samba.git/python/samba/kcc, branch talloc-2.1.13

samba python libs: convert print func to be py2/py3 compatible

2018-03-23T06:28:23+00:00

Signed-off-by: Noel Power 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall

kcc_utils: Use lower name in automatic sites covered

2018-03-21T03:36:22+00:00

This allows easier testing, as well as some consistency in the DNS
record creation.

Signed-off-by: Garming Sam 
Reviewed-by: Douglas Bagnall

kcc_utils: Prevent multiple sites attached to a sitelink covering a site

2018-03-21T03:36:22+00:00

This avoids trivial duplicates in a similar manner as mentioned in:

https://blogs.technet.microsoft.com/askds/2011/04/29/sites-sites-everywhere/

It prefers the largest sites then the earliest alphabetically, so that
only a single site ever covers an uncovered site (within a site link).
Note that this isn't applicable over multiple site links (like Windows
presumably) and is only a simple mechanism to avoid excessive
registering.  DCs within the site will also still register for each.

Signed-off-by: Garming Sam 
Reviewed-by: Douglas Bagnall

kcc_utils: Keep a count of the DCs in each site

2018-03-21T03:36:22+00:00

This is useful for ranking which sites are preferable within the same
site link.

Signed-off-by: Garming Sam 
Reviewed-by: Douglas Bagnall

kcc_utils: Add a routine for automatic site coverage

2018-03-21T03:36:21+00:00

This allows double-coverage if two links exist with the same cost.
Administrators should only connect an DC-less site via a single site
link.

This also allows unnecessary coverage by all sites in the adjoining site
link (to be resolved in the later patches).

Signed-off-by: Garming Sam 
Reviewed-by: Douglas Bagnall

samba python libs: convert 'except X, (tuple)' to 'except X as e'

2018-02-28T22:01:40+00:00

In addition to converting the except line another line is also added
for each except to extract the tuple contents.

Signed-off-by: Noel Power 
Reviewed-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

samba python libs: convert 'except X, e' to 'except X as e'

2018-02-14T23:18:30+00:00

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

samba_kcc: do not commit new nTDSConnection, if we are rodc

2018-01-13T21:01:49+00:00

Traceback (most recent call last):
/usr/local/samba/sbin/samba_kcc:   File "/usr/local/samba/sbin/samba_kcc", line 337, in 
/usr/local/samba/sbin/samba_kcc:     attempt_live_connections=opts.attempt_live_connections)
/usr/local/samba/sbin/samba_kcc:   File "/usr/local/samba/lib/python2.7/site-packages/samba/kcc/__init__.py", line 2644, in run
/usr/local/samba/sbin/samba_kcc:     all_connected = self.intersite(ping)
/usr/local/samba/sbin/samba_kcc:   File "/usr/local/samba/lib/python2.7/site-packages/samba/kcc/__init__.py", line 1883, in intersite
/usr/local/samba/sbin/samba_kcc:     all_connected = self.create_intersite_connections()
/usr/local/samba/sbin/samba_kcc:   File "/usr/local/samba/lib/python2.7/site-packages/samba/kcc/__init__.py", line 1817, in create_intersite_connections
/usr/local/samba/sbin/samba_kcc:     part, True)
/usr/local/samba/sbin/samba_kcc:   File "/usr/local/samba/lib/python2.7/site-packages/samba/kcc/__init__.py", line 1769, in create_connections
/usr/local/samba/sbin/samba_kcc:     partial_ok, detect_failed)
/usr/local/samba/sbin/samba_kcc:   File "/usr/local/samba/lib/python2.7/site-packages/samba/kcc/__init__.py", line 1594, in create_connection
/usr/local/samba/sbin/samba_kcc:     lbh.commit_connections(self.samdb)
/usr/local/samba/sbin/samba_kcc:   File "/usr/local/samba/lib/python2.7/site-packages/samba/kcc/kcc_utils.py", line 827, in commit_connections
/usr/local/samba/sbin/samba_kcc:     connect.commit_added(samdb, ro)
/usr/local/samba/sbin/samba_kcc:   File "/usr/local/samba/lib/python2.7/site-packages/samba/kcc/kcc_utils.py", line 1123, in commit_added
/usr/local/samba/sbin/samba_kcc:     (self.dnstr, estr))
/usr/local/samba/sbin/samba_kcc: samba.kcc.kcc_utils.KCCError: Could not add nTDSConnection for (CN=862f0429-c72c-4a81-ae9a-96820bb2f96d,CN=NTDS Settings,
CN=BUILDHOST,CN=Servers,CN=Testsite,CN=Sites,CN=Configuration,DC=samdom,DC=com) - (Invalid LDB reply type 1)
../source4/dsdb/kcc/kcc_periodic.c:693: Failed samba_kcc - NT_STATUS_ACCESS_DENIED

Signed-off-by: Andrej Gessel 
Reviewed-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Karolin Seeger 
Autobuild-Date(master): Sat Jan 13 22:01:49 CET 2018 on sn-devel-144

samba_kcc: simplify NCReplica.set_instantiated_flags()

2018-01-13T16:37:07+00:00

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

samba_kcc: simplify NCReplica constructor

2018-01-13T16:37:07+00:00

There is nothing to be gained from setting the dn and guid separately
except subtle bugs.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett