samba.git/python/samba/netcmd/__init__.py, branch talloc-2.4.2 Unnamed repository; edit this file 'description' to name the repository. samba-tool: try to present diagnostics for SDDL errors. 2023-11-01T20:10:46+00:00 Douglas Bagnall douglas.bagnall@catalyst.net.nz 2023-10-27T00:16:56+00:00 cc2498f35b4bc39b939069863ab5e8483aa026ec Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
netcmd: auth policy: add OptionGroup classes for user, service and computer options 2023-10-24T23:31:29+00:00 Rob van der Linde rob@catalyst.net.nz 2023-10-10T10:31:33+00:00 7c389e19212f76aaf9cba8ac8315742c7294e2c8 Signed-off-by: Rob van der Linde <rob@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
Signed-off-by: Rob van der Linde <rob@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
python: netcmd: make use of HostOptions for claims and sites commands 2023-10-24T23:31:29+00:00 Rob van der Linde rob@catalyst.net.nz 2023-10-06T02:49:27+00:00 0667708cef2e4375552860ae67ac24e6b0f593d0 Signed-off-by: Rob van der Linde <rob@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
Signed-off-by: Rob van der Linde <rob@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
python: getopt: subclass OptionParser to populate option_class 2023-10-24T23:31:29+00:00 Rob van der Linde rob@catalyst.net.nz 2023-10-19T02:05:56+00:00 837e1d9fdad79ea3a7fdce1232d8dd834f181a63 The option_class needs to be set correctly for OptionGroups that use self.add_option Override OptionParser `__init__` to change the default Option class to the samba one. Signed-off-by: Rob van der Linde <rob@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
The option_class needs to be set correctly for OptionGroups that use self.add_option

Override OptionParser `__init__` to change the default Option class to the samba one.

Signed-off-by: Rob van der Linde <rob@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
python: netcmd: catch parent exception class OptParseError instead 2023-10-24T23:31:29+00:00 Rob van der Linde rob@catalyst.net.nz 2023-10-05T23:39:30+00:00 14b2129868748d3732d5361e2b34f3a5a0a66ff2 This covers both OptionError and OptionValueError Signed-off-by: Rob van der Linde <rob@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
This covers both OptionError and OptionValueError

Signed-off-by: Rob van der Linde <rob@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
python: getopt: rename SambaOption to Option 2023-10-24T23:31:29+00:00 Rob van der Linde rob@catalyst.net.nz 2023-10-05T03:26:40+00:00 f77064c8225c79d137e225e962d885e83e113d85 * Nothing uses SambaOption directly, everything imports it through samba.netcmd.Option * Avoid an unnecessary rename on import Signed-off-by: Rob van der Linde <rob@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
 * Nothing uses SambaOption directly, everything imports it through samba.netcmd.Option
 * Avoid an unnecessary rename on import

Signed-off-by: Rob van der Linde <rob@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
python: netcmd: remove redundant Option subclass 2023-10-24T23:31:29+00:00 Rob van der Linde rob@catalyst.net.nz 2023-10-05T02:22:58+00:00 5f8c46d1decd8aea12713cb471db25a7932706d8 Instead, just import SambaOption as Option, so all the existing commands don't need changing. Signed-off-by: Rob van der Linde <rob@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
Instead, just import SambaOption as Option, so all the existing commands don't need changing.

Signed-off-by: Rob van der Linde <rob@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
python: netcmd: SUPPRESS_HELP constant has no effect here 2023-10-24T23:31:29+00:00 Rob van der Linde rob@catalyst.net.nz 2023-10-05T02:18:32+00:00 32032937ed905d5f5b9ac8ba94381e7cb03f443c Where it is used, on a few options, the constant should be used directly instead. This means that in the following commit, the Option subclass of SambaOption can be removed, as it will become redundant. Signed-off-by: Rob van der Linde <rob@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
Where it is used, on a few options, the constant should be used
directly instead.

This means that in the following commit, the Option subclass of
SambaOption can be removed, as it will become redundant.

Signed-off-by: Rob van der Linde <rob@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
python: getopt: move validators logic to parent class 2023-10-24T23:31:29+00:00 Rob van der Linde rob@catalyst.net.nz 2023-10-05T01:17:01+00:00 29c9991594f71c4fecc04f3d7701ab93e92ec7ab Signed-off-by: Rob van der Linde <rob@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
Signed-off-by: Rob van der Linde <rob@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
netcmd: don't turn exception into CommandError in run_validators 2023-10-24T23:31:29+00:00 Rob van der Linde rob@catalyst.net.nz 2023-10-05T01:03:14+00:00 bdad257a31210e7d6195212bd051f1136854ce6f It's the wrong place to do it. Instead, let it raise the original exception, capture it in _run, and call existing show_command_error method. Signed-off-by: Rob van der Linde <rob@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
It's the wrong place to do it.

Instead, let it raise the original exception, capture it in _run, and
call existing show_command_error method.

Signed-off-by: Rob van der Linde <rob@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>