samba.git/python/samba/netcmd/dns.py, branch talloc-2.3.4

python: Remove redundant assignments

2022-05-10T05:19:34+00:00

Signed-off-by: Joseph Sutton 
Reviewed-by: Andreas Schneider

samba-tool: Fix a typo

2021-09-07T18:26:33+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

samba-tool: dns update rejects malformed addresses

2021-07-05T04:16:34+00:00

Because neither filling out the struct will not necessarily tell you
you got it wrong, and the RPC could succeed in setting an arbitrary
wrong address (typically, an IPv6 address would set an A record to
"255.255.255.255").

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

samba-tool dns zoneoptions --help improvement

2021-06-10T00:29:32+00:00

Signed-off-by: Douglas Bagnall 
Reviewed-by: Jeremy Allison

samba-tool dns zoneoptions: timestamp manipulation options

2021-06-02T03:56:36+00:00

There was a bug in Samba before 4.9 that marked all records intended
to be static with a current timestamp, and all records intended to be
dynamic with a zero timestamp. This was exactly the opposite of
correct behaviour.

It follows that a domain which has been upgraded past 4.9, but on
which aging is not enabled, records intended to be static will have a
timestamp from before the upgrade date (unless their nodes have
suffered a DNS update, which due to another bug, will change the
timestmap). The following command will make these truly static:

$ samba-tool dns zoneoptions --mark-old-records-static=2018-07-23 -U...

where '2018-07-23' should be replaced by the approximate date of the
upgrade beyond 4.9.

It seems riskier making blanket conversions of static records into
dynamic records, but there are sometimes useful patterns in the names
given to machines that we can exploit. For example, if there is a
group of machines with names like 'desktop-123' that are all supposed
to using dynamic DNS, the adminstrator can go

$ samba-tool dns zoneoptions --mark-records-dynamic-regex='desktop-\d+'

and there's a --mark-records-static-regex for symmetry.

These options are deliberately long and cumbersome to type, so people
have a chance to think before they get to the end. We also introduce a
'--dry-run' (or '-n') option so they can inspect the likely results
before going ahead.

*NOTE* ageing will still not work properly after this commit, due to
other bugs that will be fixed in other commits.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

samba-tool dns: remove unused imports

2021-06-02T03:56:36+00:00

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

samba-tool dns: move dns_record_match to dnsserver.py

2021-06-02T03:56:36+00:00

This function is used here and in tests, but the tests should not be
importing things from netcmd.dns, which is really supposed to be UI
code. So we move to a common place.

the only difference is the function raises DNSParseError instead of
CommandError, and netcmd.dns has to catch and wrap that.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

samba-tool: add dns zoneoptions for aging control

2021-04-21T10:04:14+00:00

This adds a subcommand for altering zone parameters.

At the moment the only options are related to record aging (a.k.a
scavenging). The code is structured to make it easy to add more
integer or boolean options, but it is not clear that this would be
useful; many other parameters are not used or would only have
deleterious effects.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Wed Apr 21 10:04:14 UTC 2021 on sn-devel-184

samba-tool dns: use dnsserver.flag_from_string()

2021-04-08T21:54:35+00:00

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andreas Schneider

samba-tool dns: use dnsserver.record_from_string

2021-04-08T21:54:35+00:00

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andreas Schneider