samba.git/python/samba/netcmd/dsacl.py, branch talloc-2.3.4

python: use raw string for regex with escape

2020-02-07T10:37:37+00:00

Python regards 'GPT\.INI$' as a string containing an invalid escape
sequence '\.', which is ignored (i.e. treated as the literal sequence
of those 2 characters), but only after Python has grumbled to itself,
and to you if you enabled DeprecationWarnings.

The proper thing to do here is use r-strings, like r'GPT\.INI$', which
tell Python that all backslashes are literal. Alternatively (as we do
once in this patch), the backslash can itself be escaped ('\\').

There are more problems of this nature in the build scripts.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Noel Power

samba-tool dsacl: Mark old and new descriptor output correctly

2019-02-21T03:09:20+00:00

Signed-off-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall

Add command "samba-tool dsacl get" This code is very equal to "samba-tool dsacl set", except it only prints out the current sddl of an object.

2019-02-21T03:09:20+00:00

Signed-off-by: Martin Krämer 
Reviewed-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

Update dsacl.py - add_ace to handle/verify sddl parameter correct

2019-02-21T03:09:20+00:00

Test for samba-tool dsacl set --sddl parmeter

Update tests.py - add dsacl (dsacl.py / samba-tool dsacl set) test

Signed-off-by: 
Reviewed-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

python: dsal: Fix possibility of identical ACE's being added.

2019-01-18T22:19:13+00:00

Currently it is possible to add the same ace multiple times if
the case sensitivity does not match the existing one using "--sddl" parameter.
As an example while an ace

"OA;CIIO;RPWP;3e978925-8c01-11d0-afda-00c04fd930c9;bf967a86-0de6-11d0-a285-00aa003049e2;PS"

already exists a sddl

"OA;CIIO;RPWP;3E978925-8C01-11D0-AFDA-00C04FD930C9;BF967A86-0DE6-11D0-A285-00AA003049E2;PS"

can be added without detection (and can be added multiple times). As an end result
after a high number of addings (in my tests it was about 1600-1800 aces for one
object) no further changes on that object are possible.

Signed-off-by: Martin Krämer 
Reviewed-by: Jeremy Allison 
Reviewed-by: Rowland Penny 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Fri Jan 18 23:19:13 CET 2019 on sn-devel-144

PEP8: more space before equals

2018-08-24T05:49:31+00:00

This dropped out during rebase

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

PEP8: fix E303: too many blank lines (2)

2018-08-24T05:49:30+00:00

Signed-off-by: Joe Guo 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall

PEP8: fix E265: block comment should start with '# '

2018-08-24T05:49:29+00:00

Signed-off-by: Joe Guo 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall

PEP8: fix E231: missing whitespace after ','

2018-08-24T05:49:28+00:00

Signed-off-by: Joe Guo 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall

PEP8: fix E203: whitespace before ':'

2018-08-24T05:49:27+00:00

Signed-off-by: Joe Guo 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall