samba.git/python/samba/netcmd/fsmo.py, branch talloc-2.3.0

samba-tool: add 'import samba.drs_utils' to fsmo.py

2019-05-30T08:27:24+00:00

On some systems we're seeing this:

 ERROR(): uncaught exception - 'module' object has no attribute 'drs_utils'
   File "/usr/lib/python2.7/dist-packages/samba/netcmd/__init__.py", line 185, in _run
     return self.run(*args, **kwargs)
   File "/usr/lib/python2.7/dist-packages/samba/netcmd/fsmo.py", line 533, in run
     transfer_dns_role(self.outf, sambaopts, credopts, role, samdb)
   File "/usr/lib/python2.7/dist-packages/samba/netcmd/fsmo.py", line 136, in transfer_dns_role
     except samba.drs_utils.drsException as e:

E.g. it happens on debian stretch (9.9) with python 2.7.13 (on 4.10.4)

While it doesn't happen on ubuntu 18.04 with python 2.7.15rc1 or
with python 3.6.7.

There were also some reports on the mailing lists, see:
https://lists.samba.org/archive/samba-technical/2019-May/133624.html

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13973

Pair-Programmed-With: Stefan Metzmacher 

Signed-off-by: Björn Baumbach 
Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Thu May 30 08:27:24 UTC 2019 on sn-devel-184

samba-tool: use only one LDAP modify for dns partition fsmo role transfer

2019-05-30T07:12:11+00:00

We should not risk that we end with no role owner.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13973

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andrew Bartlett

samba-tool: fix replication after dns partition fsmo role transfer

2019-05-30T07:12:11+00:00

The new role owner need to replicate from the old role owner.

Before we told the old role owner to replicate from itself.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13973

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andrew Bartlett

PEP8: fix E128: continuation line under-indented for visual indent

2018-09-06T13:50:17+00:00

Signed-off-by: Joe Guo 
Reviewed-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Thu Sep  6 15:50:17 CEST 2018 on sn-devel-144

PEP8: fix E712: comparison to False should be 'if cond is False:' or 'if not cond:'

2018-08-24T05:49:31+00:00

Signed-off-by: Joe Guo 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall

PEP8: fix E303: too many blank lines (2)

2018-08-24T05:49:30+00:00

Signed-off-by: Joe Guo 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall

PEP8: fix E302: expected 2 blank lines, found 1

2018-08-24T05:49:29+00:00

Signed-off-by: Joe Guo 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall

PEP8: fix E265: block comment should start with '# '

2018-08-24T05:49:29+00:00

Signed-off-by: Joe Guo 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall

PEP8: fix E225: missing whitespace around operator

2018-08-24T05:49:28+00:00

Signed-off-by: Joe Guo 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall

PEP8: fix E128: continuation line under-indented for visual indent

2018-08-24T05:49:27+00:00

Signed-off-by: Joe Guo 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall