samba.git/python/samba/netcmd/ldapcmp.py, branch talloc-2.3.0 Unnamed repository; edit this file 'description' to name the repository. ldapcmp: ignore 'schemaInfo' if two domains are compared 2019-04-11T04:17:10+00:00 Stefan Metzmacher metze@samba.org 2019-02-21T08:20:48+00:00 b5b572d5f71e2b9783ddb25c21ac32904fbfd661 BUG: https://bugzilla.samba.org/show_bug.cgi?id=13799 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz> 
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13799

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
samba-tool ldapcmp: print DNs on predictable order 2018-11-21T06:46:20+00:00 Douglas Bagnall douglas.bagnall@catalyst.net.nz 2018-11-21T02:33:57+00:00 c4bd785ac12fe80e11e985c8c50e459be4ec9898 Rather than unstable hash order. Ideally we'd do them in proper DN order. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
Rather than unstable hash order. Ideally we'd do them in proper DN order.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
netcmd/ldapcmp: make code pythonic 2018-11-21T06:46:20+00:00 Joe Guo joeg@catalyst.net.nz 2018-11-06T09:10:55+00:00 7ebbd3731d0f510c040e7dc59532a8fb5c0f609a Signed-off-by: Joe Guo <joeg@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
netcmd/ldapcmp: promote re object to global 2018-11-21T06:46:20+00:00 Joe Guo joeg@catalyst.net.nz 2018-11-06T08:37:47+00:00 26f0992c24281514dd3ef079c1951a56277373a4 Then we can reuse the re obj. Signed-off-by: Joe Guo <joeg@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
Then we can reuse the re obj.

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
netcmd/ldapcmp: use set instead of list to compare attrs 2018-11-21T06:46:20+00:00 Joe Guo joeg@catalyst.net.nz 2018-11-06T05:16:34+00:00 7d9282bf7c02df351f976701ac6b4ed121be72f1 This will simplify the logic and improve performance. Signed-off-by: Joe Guo <joeg@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
This will simplify the logic and improve performance.

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
netcmd/ldapcmp: fix wrong way for string copy 2018-11-21T06:46:20+00:00 Joe Guo joeg@catalyst.net.nz 2018-11-06T04:41:12+00:00 10855509852f8e6bc42d5410e59e76fbf2f14657 Two mistakes here: - res[:-1] will copy but lost the last char - string is immutable in python, there is no need to copy it explicitly Signed-off-by: Joe Guo <joeg@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
Two mistakes here:

- res[:-1] will copy but lost the last char
- string is immutable in python, there is no need to copy it explicitly

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
netcmd/ldapcmp: pass --skip-missing-dn to LDAPBase 2018-11-21T06:46:19+00:00 Joe Guo joeg@catalyst.net.nz 2018-10-29T04:45:28+00:00 2851cd5bccde53a049bbd3774911b7dc4b970467 This option has default value False, and was actually not passed down from cli to LDAPBase. However, LDAPBase.__init__ has default value True for it. After the change, a few tests using ldapcmp are affected. Add --skip-missing-dn explicitly to keep the behavior consistent, otherwise test will fail. Signed-off-by: Joe Guo <joeg@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
This option has default value False, and was actually not passed down from cli
to LDAPBase. However, LDAPBase.__init__ has default value True for it.

After the change, a few tests using ldapcmp are affected.
Add --skip-missing-dn explicitly to keep the behavior consistent,
otherwise test will fail.

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
netcmd/ldapcmp: avoid modifying data while looping on dict 2018-11-21T06:46:19+00:00 Joe Guo joeg@catalyst.net.nz 2018-10-29T04:28:56+00:00 bbd082e7929010545deb5ce59e370ebe934aa23e Just define another dict for return value, seems no need to modify original dict. Signed-off-by: Joe Guo <joeg@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
Just define another dict for return value, seems no need to modify
original dict.

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
netcmd/ldapcmp: rm unused global var summary 2018-11-21T06:46:19+00:00 Joe Guo joeg@catalyst.net.nz 2018-10-29T03:44:20+00:00 047138708965d61c122dce64d57a42419e21e501 Signed-off-by: Joe Guo <joeg@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
netcmd/ldapcmp: use set instead of list to find missing DNs 2018-11-21T06:46:19+00:00 Joe Guo joeg@catalyst.net.nz 2018-10-29T02:00:15+00:00 f821f84f2e9a8489dcf8842ce716546f6f8c5ff0 This simplify the logic and improve performance a lot. Signed-off-by: Joe Guo <joeg@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
This simplify the logic and improve performance a lot.

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>