samba.git/python/samba/netcmd, branch talloc-2.3.3

samba-tool: dns update rejects malformed addresses

2021-07-05T04:16:34+00:00

Because neither filling out the struct will not necessarily tell you
you got it wrong, and the RPC could succeed in setting an arbitrary
wrong address (typically, an IPv6 address would set an A record to
"255.255.255.255").

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

samba-tool: Demote computer to wellknown container

2021-06-22T01:14:37+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=9143
Signed-off-by: David Mulder 
Reviewed-by: Andrew Bartlett

samba-tool: Disable AD DC options in samba-tool domain

2021-06-20T22:06:36+00:00

Signed-off-by: David Mulder 
Reviewed-by: Andrew Bartlett

netcmd: Incorrect arguments to Exception constructor

2021-06-17T05:12:03+00:00

Discovered by Semmle code analysis:
https://lgtm.com/projects/g/samba-team/samba

Signed-off-by: Garming Sam 
Reviewed-by: Douglas Bagnall 

Autobuild-User(master): Douglas Bagnall 
Autobuild-Date(master): Thu Jun 17 05:12:03 UTC 2021 on sn-devel-184

netcmd: Avoid conflicting SIDs when creating an offline backup

2021-06-11T07:41:38+00:00

To allow the new DC object to be created in a restored domain while
avoiding conflicts with existing SIDS, we fetch a SID that is available
at the time of backing up and store it in the backed-up database.
However, if a new security principal is created on this DC during the
backup process, the stored SID may be reused for that object, resulting
in an error on restoration.

By getting the SID for restore only after all the database files have
been backed up, we ensure that the chosen SID does not conflict with any
objects in the backed-up database.

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall

netcmd: Use next_free_rid() function to calculate a SID for restoring a backup

2021-06-11T07:41:38+00:00

This means we won't get errors if the DC doesn't have a rIDNextRID
attribute, but we will still error if there is no RID Set or if all its
pools are exhausted.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14669

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall

netcmd: Refactor seizing DNS roles while restoring from a backup

2021-06-11T07:41:38+00:00

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall

netcmd: Use correct path for state directory during offline backup

2021-06-11T07:41:38+00:00

During the restore process, we use make_smbconf() to create a new
smb.conf file with the default paths. The default location for 'state
directory' is 'state', but we currently rename this directory to
'statedir' on backing up, so it will end up pointing to a non-existent
directory. This commit ensures the names are consistent.

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall

netcmd: Fix error-checking condition

2021-06-11T07:41:38+00:00

This condition probably meant to check the argument of the most recently
thrown exception, rather than the previous one again.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14669

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall

samba-tool: stick to the point with --version

2021-06-10T00:29:32+00:00

We were doing this:

    $ bin/samba-tool --version
    samba-tool: no such subcommand: --version

    4.15.0pre1-DEVELOPERBUILD
    $

which is silly. Now we'll just see the version.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Jeremy Allison