samba.git/python/samba/provision, branch talloc-2.2.0

tests: Make IPv4 assumption explicit

2019-03-14T02:12:19+00:00

This test is asserting the expected number of *IPv4* addresses, not any
interface address (including IPv6). It works currently because the
selftest client doesn't have an IPv6 address in its smb.conf.

This patch makes the IPv4 assumption explicit by importing
interface_ips_v4() from the provision code. We need to tweak this to
pass through an 'all_interfaces' flag, otherwise it filters out the
loopback IP addresses that the testenv is using.

Signed-off-by: Tim Beale 
Reviewed-by: Andrew Bartlett

python/samba/provision: PY3 port samba4.dlz_bind9.version

2018-11-14T04:07:15+00:00

Signed-off-by: Noel Power 
Reviewed-by: Andrew Bartlett

provision/backend: LDAPBackendResult takes no creds

2018-11-01T04:08:12+00:00

Signed-off-by: Douglas Bagnall 
Reviewed-by: Noel Power

provision/backend: fix formating syntax

2018-11-01T04:08:12+00:00

Signed-off-by: Douglas Bagnall 
Reviewed-by: Noel Power

provision: fix string formatting (number of args)

2018-11-01T04:08:12+00:00

Signed-off-by: Douglas Bagnall 
Reviewed-by: Noel Power

provision: fix string format syntax

2018-11-01T04:08:12+00:00

Signed-off-by: Douglas Bagnall 
Reviewed-by: Noel Power

Python provision: remove "ExistingBackend"

2018-11-01T04:08:12+00:00

This was unused and broken. e.g. here:

-    def init(self):
-        # Check to see that this 'existing' LDAP backend in fact exists
-        ldapi_db = Ldb(self.ldapi_uri)

there is no attribute self.ldapi_uri, so this would always raise an
exception.

It was being left around in case it became useful, but that doesn't
seem to be happening.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Noel Power

python: do not use "is" for string equality

2018-10-29T22:13:36+00:00

This is not always going to work, and is not guaranteed to be
consistent even between minor versions.

Here is a simple counterexample:

>>> a = 'hello'
>>> a is 'hello'
True
>>> a is 'hello'.lower()
False
>>> a == a.lower()
True

Possibly it always works for the empty string, but we cannot rely
on that.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andreas Schneider 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Mon Oct 29 23:13:36 CET 2018 on sn-devel-144

python/provision: remove unused imports

2018-10-25T19:45:53+00:00

Signed-off-by: Douglas Bagnall 
Reviewed-by: Noel Power

python/samba/provision: PY3 PY3 port samba4.blackbox.provision-backend

2018-10-23T03:50:29+00:00

Enclose filter with list as filter object has no 'len' method

Signed-off-by: Noel Power 
Reviewed-by: Andrew Bartlett