samba.git/python/samba/samdb.py, branch talloc-2.3.1

samba-tool: implement contact management commands

2019-07-04T02:07:21+00:00

Usage: samba-tool contact 

Contact management.

Available subcommands:
  create  - Create a new contact.
  delete  - Delete a contact.
  edit    - Modify a contact.
  list    - List all contacts.
  move    - Move a contact object to an organizational unit or container.
  show    - Display a contact.

Signed-off-by: Björn Baumbach 
Reviewed-by: Andrew Bartlett

Spelling fix s/informations/information/

2019-04-02T01:12:10+00:00

Signed-off-by: Mathieu Parent 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Martin Schwenke

python/samba: PY3 fix failing py3 samba.tests.group_audit test

2018-12-10T09:38:22+00:00

Fix bytes being compared against ldb.bytes

Signed-off-by: Noel Power 
Reviewed-by: Andrew Bartlett

python/samba: PY3 don't call str for bytes (or str)

2018-12-10T09:38:22+00:00

Note: Fix needed also for gpo.apply

minPwdAge, maxPwdAge, minPwdLength & set_pwdProperties all
have a line like

value = str(value).encode('utf8')

this is a generic type statement I guess to convert int, float etc
to utf8 encoded bytes representing the string value for those.

This worked fine in PY2 but in py3 some routine already are passing
bytes into these methods, in these cases e.g. b'200' will get converted
to "b'200'", this change only performs the conversion above for non
bytes (or str) types by replacing the above with

        if not isinstance(value, binary_type):
            value = str(value).encode('utf8')

Signed-off-by: Noel Power 
Reviewed-by: Andrew Bartlett

python: do not use "is" for string equality

2018-10-29T22:13:36+00:00

This is not always going to work, and is not guaranteed to be
consistent even between minor versions.

Here is a simple counterexample:

>>> a = 'hello'
>>> a is 'hello'
True
>>> a is 'hello'.lower()
False
>>> a == a.lower()
True

Possibly it always works for the empty string, but we cannot rely
on that.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andreas Schneider 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Mon Oct 29 23:13:36 CET 2018 on sn-devel-144

python/samdb: properly use property()

2018-10-29T19:09:25+00:00

Python's property() function works like this:

property([getter[, setter[, delete[, doc]]]])

but we have been forgetting the delete function, or rather setting it
to be a string. A string is not callable and is unlikely to succeed at
deleting the property.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andreas Schneider

python/samba/netcmd: changes for samab.tests.samba_tool.computer

2018-09-03T01:22:23+00:00

Signed-off-by: Noel Power 
Reviewed-by: Andrew Bartlett

python/samba: port changes to allow samba.tests.dsdb_lock to work with PY3/PY2

2018-09-03T01:22:20+00:00

Signed-off-by: Noel Power 
Reviewed-by: Andrew Bartlett

PEP8: better formatting of (CONST1|CONST2)

2018-08-24T05:49:31+00:00

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

PEP8: fix E713: test for membership should be 'not in'

2018-08-24T05:49:31+00:00

Signed-off-by: Joe Guo 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall