samba.git/python/samba/subunit, branch talloc-2.4.0

python:subunit: Avoid misleading "Test was never started" error message

2021-06-11T08:38:34+00:00

subunithelper.py keeps track of tests that have been started, and
displays an error message if a test reports an outcome without having
previously been started. However, it makes the assumption that a test
has finished once it has reported a single outcome. This means that a
misleading error message will be displayed if it receives multiple
outcomes from the same test (which can happen if a test using the Python
unittest framework does not complete successfully, and the cleanup
subsequently fails), and any actual errors from the cleanup remain
undisplayed.

This commit ensures that only a single outcome is reported for each
test, and only after the test has finished. Outcomes are buffered up
until the stopTest() function is called, when a single outcome is
determined and all errors received for that test are output.

FilterOps still needs to output test outcomes immediately rather than
buffering them, otherwise they are never picked up and passed on to the
remote test case by subunithelper.parse_results(). This would result in
an error as the test would be considered to have never finished.

    Example subunitrun output before the change:

time: 2021-04-28 01:28:49.862123Z
test: samba.tests.example.ExampleTests.test
time: 2021-04-28 01:28:49.862215Z
failure: samba.tests.example.ExampleTests.test [
Traceback (most recent call last):
  File "bin/python/samba/tests/example.py", line 28, in test
    self.fail()
AssertionError: None
]
time: 2021-04-28 01:28:49.862407Z
failure: samba.tests.example.ExampleTests.test [
Traceback (most recent call last):
  File "bin/python/samba/tests/example.py", line 31, in tearDown
    self.fail()
AssertionError: None
]
time: 2021-04-28 01:28:49.862467Z
time: 2021-04-28 01:28:49.862510Z

    and after:

time: 2021-04-28 01:29:19.949347Z
test: samba.tests.example.ExampleTests.test
time: 2021-04-28 01:29:19.949440Z
time: 2021-04-28 01:29:19.949590Z
time: 2021-04-28 01:29:19.949640Z
failure: samba.tests.example.ExampleTests.test [
Traceback (most recent call last):
  File "bin/python/samba/tests/example.py", line 28, in test
    self.fail()
AssertionError: None
Traceback (most recent call last):
  File "bin/python/samba/tests/example.py", line 31, in tearDown
    self.fail()
AssertionError: None
]
time: 2021-04-28 01:29:19.949702Z

Signed-off-by: Joseph Sutton 
Reviewed-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett

python:subunit: Remove write_traceback()

2021-06-11T08:38:34+00:00

This functionality is already present in the Python unittest framework,
and so is not necessary to include here.

Signed-off-by: Joseph Sutton 
Reviewed-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett

python:subunit: Fix skipping a test with no reason given

2021-06-11T08:38:34+00:00

Not specifying a reason means addSkip() is passed an empty string rather
than None. As a result, this condition was never hit, and the call to
_addOutcome() had an incorrect parameter.

Signed-off-by: Joseph Sutton 
Reviewed-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett

selftest: Directly import python-iso8601

2021-02-02T18:48:35+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Alexander Bokovoy

python:subunit: Use UTC timezone from datatime module

2021-02-02T18:48:35+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Alexander Bokovoy

python: Remove remaining references to third_party python libs

2020-08-21T00:12:51+00:00

For now at least we do not have any in third_party.

Signed-off-by: Andrew Bartlett 
Reviewed-by: David Mulder 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Fri Aug 21 00:12:52 UTC 2020 on sn-devel-184

subunit/run.py: change shebang to python3

2019-03-07T13:03:56+00:00

always use explicit python version at current stage.

Signed-off-by: Joe Guo 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Noel Power 

Autobuild-User(master): Noel Power 
Autobuild-Date(master): Thu Mar  7 13:03:56 UTC 2019 on sn-devel-144

subunit/run.py: make iso8601 UTC usage python 2/3 compatible

2019-03-07T12:01:25+00:00

In `iso8601/iso8601.py`:

    if sys.version_info >= (3, 2, 0):
        UTC = datetime.timezone.utc
        ...
    else:
        class Utc(datetime.tzinfo):
            ...

        UTC = Utc()

The class `Utc` is only available for python < 3.2.0.
Use `UTC` instance instead, which is python 2/3 compatible.

Signed-off-by: Joe Guo 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Noel Power

PEP8: fix E701: multiple statements on one line (colon)

2018-08-24T05:49:30+00:00

Signed-off-by: Joe Guo 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall

PEP8: fix E211: whitespace before '('

2018-08-24T05:49:27+00:00

Signed-off-by: Joe Guo 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall