samba.git/python/samba/tests/dcerpc, branch talloc-2.4.2

tests/dcerpc: Remove unused imports

2023-12-08T02:28:33+00:00

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

tests/dcerpc: Correct docstring

2023-12-08T02:28:33+00:00

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

python: Correct Python2 super() calls that called the wrong class

2023-11-30T01:05:32+00:00

These changes have been checked as safe as skipping a superclass
has no actual impact.

Signed-off-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall

python: tests: update all super calls to python 3 style in tests

2023-11-30T01:05:32+00:00

Signed-off-by: Rob van der Linde 
Reviewed-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett 

[abartlet@samba.org Some python2 style super() calls remain due
 to being an actual, even if reasonable, behaviour change]

python: get rid of pointless empty overridden methods

2023-11-30T01:05:32+00:00

Signed-off-by: Rob van der Linde 
Reviewed-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

python: PEP275: docstrings should always use double quotes

2023-11-30T01:05:32+00:00

Signed-off-by: Rob van der Linde 
Reviewed-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

python: Remove unused imports

2023-08-30T02:15:29+00:00

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

mdssvc: reduce pagesize to 50

2023-07-26T22:43:38+00:00

Lastest macOS queries additional file metadata per search result, which causes
the mashalled paged result set including metadata to exceed the 64 KB result
fragment buffer.

Lacking fragementation support in mdssvc (it's supported by the protocol), for
now just reduce the maximum number of results per search page.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15342

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

tests/mdssvc: match hits:total:value to be the actual amount of entries in hits

2023-07-26T22:43:38+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15342

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

CVE-2023-34968: mdscli: return share relative paths

2023-07-21T12:05:35+00:00

The next commit will change the Samba Spotlight server to return absolute paths
that start with the sharename as "/SHARENAME/..." followed by the share path
relative appended.

So given a share

  [spotlight]
    path = /foo/bar
    spotlight = yes

and a file inside this share with a full path of

  /foo/bar/dir/file

previously a search that matched this file would returns the absolute
server-side pato of the file, ie

  /foo/bar/dir/file

This will be change to

  /spotlight/dir/file

As currently the mdscli library and hence the mdsearch tool print out these
paths returned from the server, we have to change the output to accomodate these
fake paths. The only way to do this sensibly is by makeing the paths relative to
the containing share, so just

  dir/file

in the example above.

The client learns about the share root path prefix – real server-side of fake in
the future – in an initial handshake in the "share_path" out argument of the
mdssvc_open() RPC call, so the client can use this path to convert the absolute
path to relative.

There is however an additional twist: the macOS Spotlight server prefixes this
absolute path with another prefix, typically "/System/Volumes/Data", so in the
example above the full path for the same search would be

  /System/Volumes/Data/foo/bar/dir/file

So macOS does return the full server-side path too, just prefixed with an
additional path. This path prefixed can be queried by the client in the
mdssvc_cmd() RPC call with an Spotlight command of "fetchPropertiesForContext:"
and the path is returned in a dictionary with key "kMDSStorePathScopes". Samba
just returns "/" for this.

Currently the mdscli library doesn't issue this Spotlight RPC
request (fetchPropertiesForContext), so this is added in this commit. In the
end, all search result paths are stripped of the combined prefix

  kMDSStorePathScopes + share_path (from mdssvc_open).

eg

  kMDSStorePathScopes = /System/Volumes/Data
  share_path = /foo/bar
  search result = /System/Volumes/Data/foo/bar/dir/file
  relative path returned by mdscli = dir/file

Makes sense? :)

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15388

Signed-off-by: Ralph Boehme 
Reviewed-by: Stefan Metzmacher