samba.git/python/samba/tests/dns.py, branch talloc-2.3.3

samba-tool dns: move dns_record_match to dnsserver.py

2021-06-02T03:56:36+00:00

This function is used here and in tests, but the tests should not be
importing things from netcmd.dns, which is really supposed to be UI
code. So we move to a common place.

the only difference is the function raises DNSParseError instead of
CommandError, and netcmd.dns has to catch and wrap that.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

python: remove all 'from future import print_function'

2021-04-28T03:43:34+00:00

This made Python 2's print behave like Python 3's print().

In some cases, where we had:

   from __future__ import print_function
   """Intended module documentation..."""

this will have the side effect of making the intended module documentation
work as the actual module documentation (i.e. becoming __doc__), because
it is once again the first statement in the module.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

pytests/dns: use dnsserver.record_from_string

2021-04-08T21:54:35+00:00

not netcmd.dns.data_to_dns_record, which is a UI function.

The only practical difference is it will raise DNSParseError, not CommandError.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andreas Schneider

pytests/dns: import dnsserver.TXTRecord directly

2021-04-08T21:54:35+00:00

Not through samba-tool, which should not be used as a library.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andreas Schneider

pytest/dns: use self.assertIn() and .assertNotIn()

2021-03-29T23:20:37+00:00

These give a more detailed message than assertTrue(x in y).

They were new in Python 3.1, so we avoided them until recently.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Jeremy Allison

pytest/dns: remove redundant argument

2021-03-29T23:20:37+00:00

We are always setting zone to the same thing which we already know,
and we can reduce cognative stress by mentioning it less and not doing
that weird pop thing.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Jeremy Allison

selftest: Add test for handling of "short" dnsProperty records

2020-05-15T06:05:30+00:00

These have been known to be given by Windows DCs that share the same domain
as while invalid, they are not format-checked inbound when set by the DNS
Manager MMC applet over the dnsserver pipe to Windows.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14310

Signed-off-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall

pytests: heed assertEquals deprecation warning en-masse

2020-02-07T10:37:37+00:00

TestCase.assertEquals() is an alias for TestCase.assertEqual() and
has been deprecated since Python 2.7.

When we run our tests with in python developer mode (`PYTHONDEVMODE=1
make test`) we get 580 DeprecationWarnings about this.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Noel Power

selftest: Test behaviour of DNS scavenge with an existing dNSTombstoned value

2020-02-06T16:24:25+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14258

Signed-off-by: Andrew Bartlett 
Reviewed-by: Stefan Metzmacher 

Autobuild-User(master): Stefan Metzmacher 
Autobuild-Date(master): Thu Feb  6 16:24:25 UTC 2020 on sn-devel-184

dns: Extend DNS tests to check the SOA record is always returned

2019-11-08T11:01:29+00:00

Signed-off-by: Samuel Cabrero 
Reviewed-by: Andreas Schneider