samba.git/python/samba/tests/domain_backup.py, branch master

python:tests: Permit expected_count to be zero

2025-05-26T02:41:37+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15852

Signed-off-by: Jennifer Sutton 
Reviewed-by: Douglas Bagnall

python:tests: Decode stdout for greater readability

2025-05-26T02:41:37+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15852

Signed-off-by: Jennifer Sutton 
Reviewed-by: Douglas Bagnall

python:tests: Test that secret keys and confidential attributes are not included in a --no-secrets backup

2025-05-26T02:41:36+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15852

Signed-off-by: Jennifer Sutton 
Reviewed-by: Douglas Bagnall

python:tests: Account for new user ‘joe’

2024-08-04T00:32:39+00:00

Signed-off-by: Jo Sutton 
Reviewed-by: Douglas Bagnall

python: Add test for checking the SHA256SUM

2024-06-06T20:25:36+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett

python:tests: Rename parameter to be consistent with overridden method

2023-12-21T20:21:34+00:00

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

python: tests: update all super calls to python 3 style in tests

2023-11-30T01:05:32+00:00

Signed-off-by: Rob van der Linde 
Reviewed-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett 

[abartlet@samba.org Some python2 style super() calls remain due
 to being an actual, even if reasonable, behaviour change]

python:samba:tests: Fix code spelling

2023-06-23T13:44:31+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett

python:tests: Fix domain_backup test with Python 3.11

2023-02-20T21:58:32+00:00

Traceback (most recent call last):
  File "bin/python/samba/tests/domain_backup.py", line 615, in test_backup_restore_with_conf
    self._test_backup_restore_with_conf()
  File "bin/python/samba/tests/domain_backup.py", line 244, in _test_backup_restore_with_conf
    self.restore_backup(backup_file, ["--configfile=" + smbconf])
  File "bin/python/samba/tests/domain_backup.py", line 421, in restore_backup
    self.run_cmd(args)
  File "bin/python/samba/tests/domain_backup.py", line 384, in run_cmd
    self.cleanup_tempdir()
  File "bin/python/samba/tests/domain_backup.py", line 370, in cleanup_tempdir
    shutil.rmtree(filepath)
  File "/usr/lib64/python3.11/shutil.py", line 732, in rmtree
    _rmtree_safe_fd(fd, path, onerror)
  File "/usr/lib64/python3.11/shutil.py", line 635, in _rmtree_safe_fd
    onerror(os.scandir, path, sys.exc_info())
  File "/usr/lib64/python3.11/shutil.py", line 631, in _rmtree_safe_fd
    with os.scandir(topfd) as scandir_it:
         ^^^^^^^^^^^^^^^^^
NotADirectoryError: [Errno 20] Not a directory:
  'st/tmp/tmp7usvex3t/samba-backup-2023-02-08T10-13-18.461113.tar.bz2'

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15308

Signed-off-by: Andreas Schneider 
Reviewed-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

CVE-2007-4559 python: ensure sanity in our tarfiles

2022-10-04T03:48:43+00:00

Python's tarfile module is not very careful about paths that step out
of the target directory. We can be a bit better at little cost.

This was reported in 2007[1], and has recently been publicised [2, for
example].

We were informed of this bug in December 2021 by Luis Alberto López
Alvar, but decided then that there were no circumstances under which
this was a security concern. That is, if you can alter the backup
files, you can already do worse things. But there is a case to guard
against an administrator being tricked into trying to restore a file
that isn't based on a real backup.

[1] https://nvd.nist.gov/vuln/detail/CVE-2007-4559
[2] https://www.theregister.com/2022/09/22/python_vulnerability_tarfile/

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15185

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Tue Oct  4 03:48:43 UTC 2022 on sn-devel-184