samba.git/python/samba/tests/kcc, branch talloc-2.3.3

pytests: heed assertEquals deprecation warning en-masse

2020-02-07T10:37:37+00:00

TestCase.assertEquals() is an alias for TestCase.assertEqual() and
has been deprecated since Python 2.7.

When we run our tests with in python developer mode (`PYTHONDEVMODE=1
make test`) we get 580 DeprecationWarnings about this.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Noel Power

python/tests/kcc_utils: disambiguate/unshadow a test

2018-10-25T19:45:59+00:00

Pair-programmed-with: Garming Sam 
Signed-off-by: Douglas Bagnall 
Reviewed-by: Noel Power

python/tests/kcc_: avoid imports

2018-10-25T19:45:56+00:00

Signed-off-by: Douglas Bagnall 
Reviewed-by: Noel Power

python/tests/kcc.graph: avoid import *

2018-10-25T19:45:56+00:00

Signed-off-by: Douglas Bagnall 
Reviewed-by: Noel Power

py/tests: remove unused imports

2018-10-25T19:45:55+00:00

Signed-off-by: Douglas Bagnall 
Reviewed-by: Noel Power

py3_tests/kcc : test_verify can hit KCCError as well as GraphError

2018-10-18T08:04:02+00:00

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

py3/tests/kcc: turn error into failure for flapping.d/kcc

2018-10-18T08:04:02+00:00

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

python/tests: turn GraphError into failure inside of test_verify()

2018-10-02T12:12:13+00:00

That test was already marked as flapping in commit
5a73f904e192c44e304850287ac439d0b52f7be5.

However the test generates an UNEXPECTED(error)
instead of an UNEXPECTED(failure).

  [67(594)/75 at 36m28s] samba.tests.kcc.python3(vampire_dc)
  repsFrom source DSA guid (62f01940-a784-4e60-947a-a661c787c8cc) not found
  repsFrom source DSA guid (62f01940-a784-4e60-947a-a661c787c8cc) not found
  repsFrom source DSA guid (62f01940-a784-4e60-947a-a661c787c8cc) not found
  repsFrom source DSA guid (62f01940-a784-4e60-947a-a661c787c8cc) not found
  repsFrom source DSA guid (62f01940-a784-4e60-947a-a661c787c8cc) not found
  UNEXPECTED(error): samba.tests.kcc.python3.samba.tests.kcc.KCCTests.test_verify(vampire_dc)
  REASON: Exception: Exception: Traceback (most recent call last):
    File "bin/python/samba/tests/kcc/__init__.py", line 80, in test_verify
      attempt_live_connections=False)
    File "bin/python/samba/kcc/__init__.py", line 2659, in run
      ('connected',))
    File "bin/python/samba/kcc/__init__.py", line 2513, in plot_all_connections
      vertex_colors=vertex_colours)
    File "bin/python/samba/kcc/graph_utils.py", line 334, in verify_and_dot
      for p, e, doc in errors)))
  samba.kcc.graph_utils.GraphError: The 'dsa_final CN=NTDS Settings,CN=LOCALVAMPIREDC,CN=Servers,CN=Default-First-Site-Name,CN=Sites,CN=Configuration,DC=samba,DC=example,DC=com' graph lacks the following properties:
  connected: the graph is not connected, as the following vertices are unreachable:

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andreas Schneider

python tests: fix format() strings for Python 2.6

2018-09-21T18:04:23+00:00

Python 2.6 wants "{0}".format(x), not "{}".format(x).

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

PEP8: fix E303: too many blank lines (2)

2018-08-24T05:49:30+00:00

Signed-off-by: Joe Guo 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall