samba.git/python/samba/tests/posixacl.py, branch talloc-2.3.3

tests/pysmbd: fill session unix info in ntacl tests

2020-06-05T10:32:31+00:00

Valid unix info is required.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=14400

Signed-off-by: Björn Baumbach 
Reviewed-by: Ralph Boehme

pytests: heed assertEquals deprecation warning en-masse

2020-02-07T10:37:37+00:00

TestCase.assertEquals() is an alias for TestCase.assertEqual() and
has been deprecated since Python 2.7.

When we run our tests with in python developer mode (`PYTHONDEVMODE=1
make test`) we get 580 DeprecationWarnings about this.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Noel Power

pysmbd: add "session_info" arg to py_smbd_get_sys_acl()

2019-12-20T11:41:42+00:00

Signed-off-by: Ralph Boehme 
Reviewed-by: Stefan Metzmacher

pysmbd: make "session_info" arg to py_smbd_get_nt_acl() mandatory

2019-12-20T11:41:42+00:00

Signed-off-by: Ralph Boehme 
Reviewed-by: Stefan Metzmacher

pysmbd: make "session_info" arg to py_smbd_set_nt_acl() mandatory

2019-12-20T11:41:42+00:00

Signed-off-by: Ralph Boehme 
Reviewed-by: Stefan Metzmacher

pysmbd: add "session_info" arg to py_smbd_unlink()

2019-12-20T11:41:42+00:00

Signed-off-by: Ralph Boehme 
Reviewed-by: Stefan Metzmacher

pysmbd: add "session_info" arg to py_smbd_chown()

2019-12-20T11:41:42+00:00

Signed-off-by: Ralph Boehme 
Reviewed-by: Stefan Metzmacher

pysmbd: add "session_info" arg to py_smbd_set_simple_acl()

2019-12-20T11:41:42+00:00

Signed-off-by: Ralph Boehme 
Reviewed-by: Stefan Metzmacher

python/tests: use a system session_info in posixacl.py

2019-12-20T11:41:42+00:00

Previously posixacl.py passed None as session_info object from
get_session_info().

That meant that the if/else branch referring to session_info:

        if nwrap_winbind_active or session_info:
             self.assertEquals(posix_acl.acl[1].a_perm, 7)
         else:
             self.assertEquals(posix_acl.acl[1].a_perm, 6)

must be tweaked to take into account that session info is now either

* a system session_info in which case we must continue to use the if branch in
  the code, or

* a user session_info in which case we must continue to go through the else
  branch

Using

  is_user_session = not session_info.security_token.is_system()

in place of just "session_info" does the trick.

Cf the classes SessionedPosixAclMappingTests and
UnixSessionedPosixAclMappingTests in posixacl.py, those are the ones that
trigger test execution with a user session.

Signed-off-by: Ralph Boehme 
Reviewed-by: Stefan Metzmacher

posixacl.py: avoid inefficient string concatenations

2019-09-24T12:22:44+00:00

Signed-off-by: Bjoern Jacke 
Reviewed-by: Matthias Dieter Wallnöfer