samba.git/python/samba/tests/samba_tool, branch talloc-2.3.3

pytest samba-tool dns: avoid testing update of '.' PTR

2021-06-22T01:14:37+00:00

This will fail for reasons that maybe we don't care about.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

pytest: samba-tool dns: allow identical updates

2021-06-22T01:14:37+00:00

We know this should work from tests of the underlying RPC calls on
Windows (see dns_aging).

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

pytest: samba-tool dns: allow valid updates

2021-06-22T01:14:37+00:00

Without this patch we will get errors like this when in-place RPC
updates start to work:

   AssertionError: unexpectedly None : Successfully updated record
   '192.168.0.1' to '192.168.0.1', even though the latter is of type
   'A' where 'A' was expected.

That's because we have always rejected updates that try to modify an
existing record. We shouldn't.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

python/samba/tests: Remove DCs joined to test samba-tool behaviour

2021-06-21T00:58:31+00:00

Otherwise we have the live DCs spamming the logs looking for the
long-gone test servers:

Failed to connect host fd00::5357:5f0b on port 135 - NT_STATUS_OBJECT_NAME_NOT_FOUND
Failed to connect host fd00::5357:5f0b (6f44653d-18c8-4bf4-b2e7-6f85cf7b0f74._msdcs.addom.samba.example.com) on port 135 - NT_STATUS_OBJECT_NAME_NOT_FOUND.
Failed to connect host 10.53.57.11 on port 135 - NT_STATUS_OBJECT_NAME_NOT_FOUND
Failed to connect host 10.53.57.11 (6f44653d-18c8-4bf4-b2e7-6f85cf7b0f74._msdcs.addom.samba.example.com) on port 135 - NT_STATUS_OBJECT_NAME_NOT_FOUND.
Failed to connect host 10.53.57.12 on port 135 - NT_STATUS_OBJECT_NAME_NOT_FOUND

This avoids spamming the GitLab pipeline logs with a lot of noise,
as there is a size limit to the output, as well as being cleaner.

Signed-off-by: Andrew Bartlett 
Reviewed-by: Gary Lockyer

python:tests: Fix group_edit test with system libldb

2021-06-20T22:52:05+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Sun Jun 20 22:52:05 UTC 2021 on sn-devel-184

python:tests: Fix user_edit test with system libldb

2021-06-20T22:06:36+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett

python:tests: Fix contact_edit test with system libldb

2021-06-20T22:06:36+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett

pytest: Fix typo in docstring

2021-06-11T07:41:38+00:00

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall

samba-tool dns zoneoptions: timestamp manipulation options

2021-06-02T03:56:36+00:00

There was a bug in Samba before 4.9 that marked all records intended
to be static with a current timestamp, and all records intended to be
dynamic with a zero timestamp. This was exactly the opposite of
correct behaviour.

It follows that a domain which has been upgraded past 4.9, but on
which aging is not enabled, records intended to be static will have a
timestamp from before the upgrade date (unless their nodes have
suffered a DNS update, which due to another bug, will change the
timestmap). The following command will make these truly static:

$ samba-tool dns zoneoptions --mark-old-records-static=2018-07-23 -U...

where '2018-07-23' should be replaced by the approximate date of the
upgrade beyond 4.9.

It seems riskier making blanket conversions of static records into
dynamic records, but there are sometimes useful patterns in the names
given to machines that we can exploit. For example, if there is a
group of machines with names like 'desktop-123' that are all supposed
to using dynamic DNS, the adminstrator can go

$ samba-tool dns zoneoptions --mark-records-dynamic-regex='desktop-\d+'

and there's a --mark-records-static-regex for symmetry.

These options are deliberately long and cumbersome to type, so people
have a chance to think before they get to the end. We also introduce a
'--dry-run' (or '-n') option so they can inspect the likely results
before going ahead.

*NOTE* ageing will still not work properly after this commit, due to
other bugs that will be fixed in other commits.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

pytest:samba-tool dns: more robust clean-up

2021-06-02T03:56:36+00:00

If setUp() fails (and here we have a big .setUp), .tearDown is not run,
and that can leave the zone undeleted, breaking all the other tests who
expect to be able to recreate it.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett