samba.git/python/samba, branch talloc-2.2.0

selftest: Remove mention of --extra-python from comment

2019-03-21T04:06:15+00:00

Signed-off-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall

py/graph: use 2.6 compatible check for set membership

2019-03-20T06:36:05+00:00

It is better this way anyway.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Wed Mar 20 06:36:05 UTC 2019 on sn-devel-144

dbcheck: don't check expired tombstone objects by default anymore

2019-03-14T03:12:27+00:00

These will be removed anyway and any change on them risks to
be an originating update that causes replication problems.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13816

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Thu Mar 14 03:12:27 UTC 2019 on sn-devel-144

dbcheck: add --selftest-check-expired-tombstones cmdline option

2019-03-14T02:12:20+00:00

This will be used by dbcheck tests which operate on static/old provision
dumps in the following commits.

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andrew Bartlett

python/samba/netcmd: provide SUPPRESS_HELP via Option class

2019-03-14T02:12:20+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13816

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andrew Bartlett

dbcheck: detect the change after deletion bug

2019-03-14T02:12:20+00:00

Old versions of 'samba-tool dbcheck' could reanimate
deleted objects, when running at the same time as the
tombstone garbage collection.

When the (deleted) parent of a deleted object
(with the DISALLOW_MOVE_ON_DELETE bit in systemFlags),
is removed before the object itself, dbcheck moved
it in the LostAndFound[Config] subtree of the partition
as an originating change. That means that the object
will be in tombstone state again for 180 days on the local
DC. And other DCs fail to replicate the object as
it's already removed completely there and the replication
only gives the name and lastKnownParent attributes, because
all other attributes should already be known to the other DC.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13816

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andrew Bartlett

dbcheck: add find_repl_attid() helper function

2019-03-14T02:12:20+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13816

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andrew Bartlett

dbcheck: don't remove dangling one-way links on already deleted objects

2019-03-14T02:12:20+00:00

This would typically happen when the garbage collection
removed a parent object before a child object (both with
the DISALLOW_MOVE_ON_DELETE bit set in systemFlags),
while dbcheck is running at the same time as the garbage collection.
In this case the lastKnownParent attributes points a non existing
object.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13816

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andrew Bartlett

dbcheck: don't move already deleted objects to LostAndFound

2019-03-14T02:12:20+00:00

This would typically happen when the garbage collection
removed a parent object before a child object (both with
the DISALLOW_MOVE_ON_DELETE bit set in systemFlags),
while dbcheck is running at the same time as the garbage collection.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13816

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andrew Bartlett

dbcheck: do isDeleted, systemFlags and replPropertyMetaData detection first

2019-03-14T02:12:20+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13816

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andrew Bartlett