samba.git/source3/client/client.c, branch talloc-2.3.2

libsmb: Remove "mntpoint" argument from cli_list() callback

2020-11-04T18:55:40+00:00

do_list()/do_list_helper() in source3/client/client.c was the only user of this
argument. And that use was wrong.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

smbclient: Fix recursive "ls" across DFS links

2020-11-04T18:55:40+00:00

This is an a bit subtle patch: The main trick is that the previous
code a DFS-style \\server\share\dir1\dir2 path ended up in the list of
directories to enumerate. This was then processed by do_list again,
passing it to cli_resolve_path. However, cli_resolve_path always
expects non-DFS style paths as input. This patch passes the original,
non-DFS path to do_list_helper(), so that it ends up without the DFS
style \\server\share prefix in the directory queue.

From general failure it just fails on the SMB1-based environments,
like the other smbclient_s3 ones in knownfail.d/smb1-tests

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

smbclient: Add "mask" to do_list_helper_state

2020-11-04T18:55:40+00:00

To me this is simpler to understand than to rely on the cli_list
callback which goes through some function call layers. Also, this
gives more obvious control over what we pass in the next patch.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

smbclient: Introduce struct do_list_helper_state

2020-11-04T18:55:40+00:00

We'll pass more information to do_list_helper() soon

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

smbclient: Wrap a few long lines

2020-11-04T18:55:40+00:00

Make the next patch simpler

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

smbclient: Move variable declarations closer to their use

2020-11-04T18:55:40+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

s3:libsmb: Remove max_protocol from cli_cm_open()

2020-10-09T19:16:46+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Jeremy Allison

s3:client: Remove global max_protocol

2020-10-09T19:16:46+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Jeremy Allison

s3:libsmb: Pass cli_credentials to cli_resolve_path(), using helper variables.

2020-10-09T19:16:46+00:00

Signed-off-by: Andreas Schneider 
Signed-off-by: Jeremy Allison

s3:libsmb: Pass cli_credentials to cli_cm_open()

2020-10-09T19:16:46+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Jeremy Allison