samba.git/source3/lib/adouble.c, branch talloc-2.3.4

Revert "vfs: remove dirfsp arg from SMB_VFS_CREATE_FILE()"

2022-04-28T13:12:33+00:00

This reverts commit 322574834f1e71bc01f21be9059ca4d386517c84.

Not strictly a revert anymore, but for future work we do need "dirfsp"
in create_file_default() passed through the VFS.

Signed-off-by: Volker Lendecke 
Reviewed-by: Ralph Boehme

smbd: Remove a few vfs_stat() calls

2022-03-11T19:19:21+00:00

openat_pathref_fsp() does not need them anymore

Signed-off-by: Volker Lendecke 
Reviewed-by: Ralph Boehme 

Autobuild-User(master): Ralph Böhme 
Autobuild-Date(master): Fri Mar 11 19:19:21 UTC 2022 on sn-devel-184

lib: Use cp_smb_filename_nostream() in adouble_path()

2022-03-01T20:09:28+00:00

No need to TALLOC_FREE(smb_fname->stream_name) later

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

smbd: Introduce metadata_fsp()

2022-02-11T20:54:37+00:00

Centralize the pattern

if (fsp->base_fsp != NULL) {
	fsp = fsp->base_fsp;
}

with a descriptive name.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

smbd: Introduce fsp_is_alternate_stream()

2022-02-11T20:54:37+00:00

To me this is more descriptive than "fsp->base_fsp != NULL". If this
turns out to be a performance problem, I would go and make this a
static inline in smbd/proto.h.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

smbd: NULL out "fsp" in close_file()

2022-02-10T18:16:36+00:00

Quite a few places already had this in the caller, but not all. Rename
close_file() to close_file_free() appropriately. We'll factor out
close_file_smb() doing only parts of close_file_free() later.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

CVE-2021-44142: libadouble: harden parsing code

2022-01-31T15:27:37+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14914

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

CVE-2021-44142: libadouble: harden ad_unpack_xattrs()

2022-01-31T15:27:37+00:00

This ensures ad_unpack_xattrs() is only called for an ad_type of ADOUBLE_RSRC,
which is used for parsing ._ AppleDouble sidecar files, and the buffer
ad->ad_data is AD_XATTR_MAX_HDR_SIZE bytes large which is a prerequisite for all
buffer out-of-bounds access checks in ad_unpack_xattrs().

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14914

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

vfs_fruit: remove a fsp check from ad_fset()

2021-11-03T16:45:32+00:00

This comes from times before we had pathref fsps. Back then if you wanted to
check if fsp->fh->fd contained a valid value != -1, you'd also first check that
the passed in fsp and fsp->fh are non NULL. With pathref fsps we don't need this
anymore.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14890
RN: Crash in vfs_fruit asking for fsp_get_io_fd() for an XATTR call

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

s3: lib: adouble.c: In ad_read_meta() we can now guarantee a valid fsp.

2021-07-04T17:15:35+00:00

There are now no more callers of SMB_VFS_GETXATTR().

Signed-off-by: Jeremy Allison 
Reviewed-by: Ralph Boehme