samba.git/source3/lib/fstring.c, branch talloc-2.4.4

s3-lib: restore truncating behavior of push_ascii_nstring()

2022-10-25T16:25:40+00:00

Some users of push_ascii_nstring() (notably name_to_unstring())
expect the output to be truncated if it would exceed the size of
an nstring after conversion. However this broke in 2011 due to
commit d546adeab5 ("Change convert_string_internal() and
convert_string_error() to bool return"). This patch restores the
old behavior.

The issue can be observed in syslog after setting the
``workgroup`` to a 16+ characters long string which triggers a
DEBUG() message:

    Oct 17 11:28:45 dev nmbd[11716]: name_to_nstring: workgroup name 0123456789ABCDEF0123456789ABCDEF is too long. Truncating to

Signed-off-by: Philipp Gesang 
Reviewed-by: Noel Power 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Noel Power 
Autobuild-Date(master): Tue Oct 25 16:25:40 UTC 2022 on sn-devel-184

s3-lib Remove more unused fstring.c functions

2011-04-13T04:47:07+00:00

Signed-off-by: Andrew Tridgell

s3-lib: Remove unused pull_ucs2_fstring()

2011-04-13T04:47:06+00:00

Signed-off-by: Andrew Tridgell

Fix convert_string() to take a *converted_size arg. and return a bool.

2011-03-30T21:59:37+00:00

Makes these interfaces much harder to misuse and easier to ensure error
checking.

Autobuild-User: Jeremy Allison 
Autobuild-Date: Wed Mar 30 23:59:37 CEST 2011 on sn-devel-104

Change convert_string_internal() and convert_string_error() to bool return.

2011-03-30T18:58:10+00:00

Move closer to makeing all convert_string_XXX functions return bool.

Autobuild-User: Jeremy Allison 
Autobuild-Date: Wed Mar 30 20:58:10 CEST 2011 on sn-devel-104

Fix the nstring calls to use the correct sizes.

2011-03-30T17:13:01+00:00

s3-string: removed last use of conv_silent

2011-03-25T03:37:06+00:00

This replaces the push_ascii_nstring() implementation with a call to
convert_string_error()

Pair-Programmed-With: Andrew Bartlett

s3-string: moved fstring functions into their own file

2011-03-25T03:37:06+00:00

Pair-Programmed-With: Andrew Bartlett