samba.git/source3/lib/gencache.c, branch talloc-2.3.1

s3:lib: Fix the debug message for adding cache entries.

2019-01-19T11:24:18+00:00

To get correct values, we need to cast 'timeout' to 'long int' first in
order to do calculation in that integer space! Calculations are don in
the space of the lvalue!

Signed-off-by: Andreas Schneider 
Reviewed-by: Volker Lendecke

lib: Fix CID 1441264 Error handling issues (CHECKED_RETURN)

2018-11-16T17:35:22+00:00

This is not worth keeping a CID around :-)

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

gencache: Prune expired entries

2018-11-06T17:57:26+00:00

This solves the problem that gencache never shrinks right
now. Whenever we write an entry, we now walk that entry's chain and
delete expired entries. This should be a good balance between
performance and cleanup actions: Reading is still unaffected, and
those who write pay a small penalty while keeping gencache size under
control.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

gencache: Wipe corrupt databases

2018-11-06T17:57:26+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

gencache: Remove transaction-based tdb

2018-11-06T17:57:26+00:00

At more than one large site I've seen significant problems due to
gencache_stabilize. gencache_stabilize was mainly introduced to
survive machine crashes with the cache still being in place. Given
that most installations crash rarely and this is still a cache, this
safety is overkill and causes real problems.

With the recent changes to tdb, we should be safe enough to run on
completely corrupted databases and properly detect errors. A further
commit will introduce code that wipes the gencache.tdb if such a
corruption is detected.

There is one kind of corruption that we don't properly handle:
Orphaned space in the database. I don't have a good idea yet how to
handle this in a graceful and efficient way during normal operations,
but maybe this idea pops up at some point.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

gencache: Add crc check

2018-11-06T17:57:26+00:00

This covers key, timestamp and data. This will detect silent
corruption of gencache data after a system crash

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

gencache: Convert to a binary timestamp

2018-11-06T17:57:26+00:00

Two reasons:

The ascii conversion shows up on profiles.

In a further commit we will get checksums for gencache entries to
protect at hidden corruption due to a crash on the non-transactioned
gencache.tdb. Next to the timestamp this is a second field that is
gencache metadata, and I don't want to deal with a second ascii number
when at least some of the gencache values are binary already.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

lib: Remove gencache.h from proto.h

2018-10-19T16:52:50+00:00

It's a pain to recompile the world if gencache.h changes

Signed-off-by: Volker Lendecke 
Reviewed-by: Andreas Schneider 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Fri Oct 19 18:52:50 CEST 2018 on sn-devel-144

gencache: Remove a redundant check

2018-10-17T20:22:51+00:00

tdb_storev itself is robust against overflow due to multiple buffers

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Wed Oct 17 22:22:51 CEST 2018 on sn-devel-144

gencache: Remove a redundant check

2018-10-17T17:22:20+00:00

gencache_pull_timeout checks for NULL ptr already

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison