samba.git/source3/lib/messages.c, branch talloc-2.4.4

lib: Give tallocmsg.c its own header

2024-03-28T08:05:35+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Andreas Schneider

s3:lib/messages*: s/getpid/tevent_cached_getpid

2022-07-25T17:34:33+00:00

Our messaging code is very performance critical and
we should note waste time in getpid() syscalls...

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Jeremy Allison

messaging: Fix receiving file descriptors

2021-03-19T08:18:26+00:00

Don't close unconsumed file descriptors in messaging_recv_cb(). Via
multiple registrations on different tevent contexts we might call
messaging_recv_cb() multiple times: All but the first tevent context
handled in the loop in msg_dgm_ref_recv() will not see file
descriptors anymore, it will just get a -1, even if the first
reference had no receiver interested in the fds.

Change the API such that consumers can set the file descriptor to -1
if it's consumed. If nobody wanted them, do the close where they were
created via recvmsg, in messages_dgm.c.

If you want multiple handlers to consume the file descriptors, you
should dup() them in the filter function handed to
messaging_filtered_read_send and save the duplicate in your private
data for later consumption.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Volker Lendecke 
Autobuild-Date(master): Fri Mar 19 08:18:26 UTC 2021 on sn-devel-184

lib: Avoid declaring zero-length VLAs in various messaging functions

2021-01-04T10:50:07+00:00

In messaging_rec_create(), messaging_recv_cb() and
messaging_dispatch_rec(), variable length arrays of file descriptors are
declared using an incoming num_fds parameter.

However, there are several scenarios where num_fds can be zero, and
declaring a zero-length VLA is undefined behavior. This can lead to
segmentation faults and/or other crashes when compiling with recent
versions of clang at high optimization levels.

To avoid ever using zero as the length for these declarations, use
MAX(1, length) instead.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14605

Signed-off-by: Dimitry Andric 
Reviewed-by: Volker Lendecke 
Reviewed-by: Ralph Boehme 

Autobuild-User(master): Ralph Böhme 
Autobuild-Date(master): Mon Jan  4 10:50:07 UTC 2021 on sn-devel-184

lib: Add tevent_req_received() to messaging_filtered_read_recv()

2020-10-21T20:27:57+00:00

Early talloc_free() for the msg_rec if it's not picked up

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Wed Oct 21 20:27:57 UTC 2020 on sn-devel-184

lib/messaging: Move messages_dgm out of source3

2020-05-06T00:06:40+00:00

... so CTDB can also use it.

Signed-off-by: Amitay Isaacs 
Reviewed-by: Volker Lendecke

lib: Use ARRAY_DEL_ELEMENT in messaging_dispatch_waiters()

2020-03-26T14:43:31+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Ralph Boehme

lib: Fix a shutdown crash with "clustering = yes"

2020-02-18T13:05:52+00:00

This is a bit confusing now, sorry for that:

register_msg_pool_usage() in the ctdb case uses
messaging_ctdb_register_tevent_context(), which talloc_reference()s
the central struct messaging_ctdb_fde_ev of the
messaging_ctdb_context. In messaging_reinit(), we talloc_free only one
of those references and allocate a new messaging_ctdb_fde_ev. The
remaining messaging_ctdb_fde_ev should have been deleted as well, but
due to the second reference this does not happen. When doing the
shutdown messaging_ctdb_fde_ev_destructor() is called twice, once on
the properly reinitialized fde_ev, and once much later on the leftover
one which references invalid data structures.

By the way, this is not a problem with talloc_reference(), this would
have happened with explicit refcounting too.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=14281

Signed-off-by: Volker Lendecke 
Reviewed-by: Martin Schwenke 
Reviewed-by: Stefan Metzmacher 

Autobuild-User(master): Björn Baumbach 
Autobuild-Date(master): Tue Feb 18 13:05:53 UTC 2020 on sn-devel-184

lib: Introduce messaging_context->per_process_talloc_ctx

2020-02-18T11:38:40+00:00

Consolidate "msg_dgm_ref" and "msg_ctdb_ref": The only purpose of
those pointers was to TALLOC_FREE() them in messaging_reinit(). We'll
have a third entity to talloc_free() in the next commit, make that
simpler.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=14281

Signed-off-by: Volker Lendecke 
Reviewed-by: Martin Schwenke 
Reviewed-by: Stefan Metzmacher

lib: Add a TALLOC_CTX to base register_msg_pool_usage() on

2020-02-18T11:38:40+00:00

Add a simple way to deactivate the registration

Bug: https://bugzilla.samba.org/show_bug.cgi?id=14281

Signed-off-by: Volker Lendecke 
Reviewed-by: Martin Schwenke 
Reviewed-by: Stefan Metzmacher