samba.git/source3/lib/messages_dgm.c, branch talloc-2.2.0

lib: Use wrapper for string to integer conversion

2019-03-01T00:32:10+00:00

In order to detect an value overflow error during
the string to integer conversion with strtoul/strtoull,
the errno variable must be set to zero before the execution and
checked after the conversion is performed. This is achieved by
using the wrapper function strtoul_err and strtoull_err.

Signed-off-by: Swen Schillig 
Reviewed-by: Ralph Böhme 
Reviewed-by: Jeremy Allison

messages_dgm: Properly handle receiver re-initialization

2019-02-14T01:18:28+00:00

This only properly covers the small-message nonblocking case. Covering
the large-message and the blocking case is a much larger effort assuming
we want to re-send the failed message if parts of the message has gone
through properly. Don't do that for now.

This was found by sanba_dnsupdate constantly recreating its irpc handle to
winbindd in the RODC case.

The messaging_dgm code cached connected datagram sockets based on the
destination pid for 1 second. Which means the IRPC responses from
winbindd are never delivered to samba_dnsupdate,
which will then hit a timeout.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13786

Signed-off-by: Volker Lendecke 
Reviewed-by: Stefan Metzmacher 
Reviewed-by: Andrew Bartlett

messages_dgm: Use saved errno value

2019-02-14T01:18:28+00:00

In this case this is just a cleanup, the value has just been set by
messaging_dgm_sendmsg. But as that already saves errno into a local
variable, use that.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13786

Signed-off-by: Volker Lendecke 
Reviewed-by: Stefan Metzmacher 
Reviewed-by: Andrew Bartlett

Revert "s3:messages: protect against usage of wrapper tevent_context objects for messaging"

2019-01-11T22:11:16+00:00

This reverts commit 7f2afc20e1b6397c364a98d1be006377c95e4665.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme 
Reviewed-by: Volker Lendecke 
Reviewed-by: Stefan Metzmacher

Revert "s3:messages: allow messaging_{dgm,ctdb}_register_tevent_context() to use wrapper tevent_context"

2019-01-11T22:11:16+00:00

This reverts commit 660cf86639753edaa7a7a21a5b5ae207ae7d4260.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme 
Reviewed-by: Volker Lendecke 
Reviewed-by: Stefan Metzmacher

s3:lib: Fix undefined behavior in messages_dgm

2018-11-22T21:13:27+00:00

source3/lib/messages_dgm.c:1290:7: runtime error: variable length array
bound evaluates to non-positive value 0

Signed-off-by: Andreas Schneider 
Reviewed-by: Gary Lockyer

s3:messages: explicitly use max_thread=unlimited for pthreadpool_tevent_init() in messaging_dgm_init()

2018-07-12T12:25:18+00:00

Currently 0 also means unlimited, but that will change soon,
to force no thread and strict sync processing.

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Ralph Boehme

s3:messages: allow messaging_{dgm,ctdb}_register_tevent_context() to use wrapper tevent_context

2018-07-11T21:04:23+00:00

This is only allowed if the raw tevent context is already registered.

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Ralph Boehme

s3:messages: protect against usage of wrapper tevent_context objects for messaging

2018-07-11T21:04:23+00:00

This makes a lot of assumtion easier to understand and the introduction
of wrapper tevent contexts will not change the existing behaviour.

We'll relax this a bit in the next commits.

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Ralph Boehme

s3:messages: check tevent_fd_get_flags() == 0 before using stale event context pointer

2018-04-24T09:13:17+00:00

If the event context got deleted, tevent_fd_get_flags() will return 0
for the stale fde.  In that case we should not use fde_ev->ev anymore.

Pair-Programmed-With: Stefan Metzmacher 

Signed-off-by: Ralph Boehme 
Signed-off-by: Stefan Metzmacher 
Reviewed-by: Volker Lendecke