samba.git/source3/lib/netapi/netapi.c, branch talloc-2.4.2

s3:netapi: Fix a leak in libnetapi_net_init()

2023-09-14T21:35:29+00:00

Allow libnetapi_net_init() to be called more than once without
leaking libnetapi_ctx allocated on a previous call, which is
currently the case in the `net rpc` code.

Signed-off-by: Pavel Kalugin 
Reviewed-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett

libnetapi: Use lpcfg_set_cmdline()

2023-09-14T21:35:29+00:00

Replace lp_set_cmdline() with lpcfg_set_cmdline() in netapi.c.
For this purpose:
1. Add loadparm_context to the libnetapi_ctx because we need it
   in libnetapi_set_debuglevel() and libnetapi_set_logfile().
2. Move loadparm_context creation from libnetapi_net_init()
   to libnetapi_init() and add the lp_ctx parameter to the former.

Signed-off-by: Pavel Kalugin 
Reviewed-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett

netapi: Pass net's cmdline credentials to libnetapi_net_init()

2023-09-11T02:42:41+00:00

Avoid unnecessary credentials allocation and initialization by passing the
net's cmdline creds to libnetapi_net_init() directly.

Fixes the problem of running cli_credentials_guess() (which runs password
callbacks) twice, one for the net's cmdline creds and a second time for the
creds initialized in libnetapi_net_init(), just to override them immediately
after.

Example:

$ export PASSWD_FD=0
$ ./bin/net offlinejoin composeodj <...>
foo
bar

Password is read from STDIN twice.

Signed-off-by: Samuel Cabrero 
Reviewed-by: Andrew Bartlett

netapi: Pass loadparm_context to libnetapi_net_init()

2023-09-11T02:42:41+00:00

The net's tool cmdline lp_ctx can be reused, no need to init a new one except
for external library users.

Signed-off-by: Samuel Cabrero 
Reviewed-by: Andrew Bartlett

s3-libnetapi: add libnetapi_set_logfile()

2021-07-14T16:49:30+00:00

Guenther

Signed-off-by: Guenther Deschner 
Reviewed-by: Alexander Bokovoy

s3-libnetapi: add libnetapi_get_use_kerberos()

2021-07-14T16:49:30+00:00

Guenther

Signed-off-by: Guenther Deschner 
Reviewed-by: Alexander Bokovoy

s3:libnetapi: Check return code of cli_credentials_guess()

2021-06-29T02:19:35+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett

auth:creds: Add obtained arg to cli_credentials_set_gensec_features()

2021-04-28T03:43:34+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett

auth:creds: Add obtained arg to cli_credentials_set_kerberos_state()

2021-04-28T03:43:34+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett

s3:netapi: Add libnetapi_set_creds()

2021-03-24T02:07:20+00:00

This will be used by the 'net' command in future!

Signed-off-by: Andreas Schneider 
Reviewed-by: Guenther Deschner 

Autobuild-User(master): Günther Deschner 
Autobuild-Date(master): Wed Mar 24 02:07:20 UTC 2021 on sn-devel-184