samba.git/source3/lib/netapi, branch master

s3:lib:netapi set talloc type for GROUP_INFO_x

2026-03-20T13:27:34+00:00

Call talloc_set_type setting the type name after copying the GROUP_INFO to the
buffer.  This will allow the client code to use talloc_get_type_abort, if needed
to suppress any cast-align warnings

Signed-off-by: Gary Lockyer 
Reviewed-by: Volker Lendecke

s3:lib: Initialize pointer to NULL

2025-08-27T03:41:36+00:00

../../source3/lib/netapi/tests/netdisplay.c: In function ‘test_netquerydisplayinformation’:
../../source3/lib/netapi/tests/netdisplay.c:87:45: error: ‘current_name’ may be used uninitialized [-Werror=maybe-uninitialized]
   87 |                                 if (name && strcasecmp(current_name, name) == 0) {
      |                                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../source3/lib/netapi/tests/netdisplay.c:37:21: note: ‘current_name’ was declared here
   37 |         const char *current_name;
      |                     ^~~~~~~~~~~~
cc1: all warnings being treated as errors

Signed-off-by: Jennifer Sutton 
Reviewed-by: Douglas Bagnall

s3:lib: Fix CID 1497484 use-after-free.

2025-07-29T15:01:42+00:00

p was not set to NULL after being free'd, this can cause a
use-after-free situation.

This fixes coverity issue#1497484

Signed-off-by: Vinit Agnihotri 
Reviewed-by: Guenther Deschner 
Reviewed-by: Anoop C S 

Autobuild-User(master): Günther Deschner 
Autobuild-Date(master): Tue Jul 29 15:01:42 UTC 2025 on atb-devel-224

libsmb: Remove "source3/libsmb/libsmb.h"

2025-06-16T15:05:32+00:00

libsmb.h added ads_status.h and cli_smb2_fnum.h. Only few users need
either.

Signed-off-by: Volker Lendecke 
Reviewed-by: Ralph Boehme

s3:libsmb: pass struct smb_transports to cli_cm_connect() and cli_cm_open()

2025-04-18T10:17:29+00:00

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Volker Lendecke

s3:rpc_client: Use cli_rpc_pipe_reopen_np_noauth() for OpenPolicy fallback

2025-02-17T17:29:37+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15680

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andreas Schneider

s3:headers: s/the the\b/the/ in comments

2024-11-06T10:57:35+00:00

Signed-off-by: Douglas Bagnall 
Reviewed-by: Volker Lendecke

s3:lib/netapi: make use of dcerpc_binding_get_abstract_syntax()

2024-09-26T15:22:46+00:00

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Ralph Boehme

s3:lib/netapi: make use of dcerpc_binding_handle_transport_session_key()

2024-09-26T15:22:45+00:00

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Ralph Boehme

lib: Use cli_credentials_add_gensec_features in a few places

2024-06-04T07:11:35+00:00

Capture a common pattern

Signed-off-by: Volker Lendecke 
Reviewed-by: Andrew Bartlett