samba.git/source3/lib/netapi, branch talloc-2.3.1

s3:libnet: Require sealed LDAP SASL connections for joining

2019-10-09T07:06:35+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Alexander Bokovoy

s3/lib/netapi: clang: Fix 'Value stored during initialization is never read'

2019-09-26T18:41:28+00:00

Fixes:

source3/lib/netapi/user.c:1290:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
        NTSTATUS status = NT_STATUS_OK;
                 ^~~~~~   ~~~~~~~~~~~~
source3/lib/netapi/user.c:1610:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
        NTSTATUS status = NT_STATUS_OK;
                 ^~~~~~   ~~~~~~~~~~~~

source3/lib/netapi/user.c:2990:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
        NTSTATUS status = NT_STATUS_OK;
                 ^~~~~~   ~~~~~~~~~~~~
source3/lib/netapi/user.c:3184:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
        NTSTATUS status = NT_STATUS_OK;
                 ^~~~~~   ~~~~~~~~~~~~
source3/lib/netapi/user.c:3522:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
        NTSTATUS status = NT_STATUS_OK;
                 ^~~~~~   ~~~~~~~~~~~~

Signed-off-by: Noel Power 
Reviewed-by: Jeremy Allison

s3/lib/netapi: clang: Fix 'Value stored during initialization is never read'

2019-09-26T18:41:27+00:00

Fixes:

source3/lib/netapi/getdc.c:173:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
        NTSTATUS status = NT_STATUS_DOMAIN_CONTROLLER_NOT_FOUND;
                 ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.

Signed-off-by: Noel Power 
Reviewed-by: Jeremy Allison

s3/lib/netapi: clang: Fix 'Value stored during initialization is never read'

2019-09-26T18:41:27+00:00

Fixes:

source3/lib/netapi/group.c:1383:11: warning: Value stored to '
status' during its initialization is never read <--[clang]
        NTSTATUS status = NT_STATUS_OK;
                 ^~~~~~   ~~~~~~~~~~~~
samba/source3/lib/netapi/group.c:1521:11: warning: Value stored to '
status' during its initialization is never read <--[clang]
        NTSTATUS status = NT_STATUS_OK;
                 ^~~~~~   ~~~~~~~~~~~~
samba/source3/lib/netapi/group.c:1718:11: warning: Value stored to '
status' during its initialization is never read <--[clang]
        NTSTATUS status = NT_STATUS_OK;
                 ^~~~~~   ~~~~~~~~~~~~
3 warnings generated.

Signed-off-by: Noel Power 
Reviewed-by: Jeremy Allison

s3:lib: Use the passed mem_ctx instead of talloc_tos()

2019-07-26T01:48:26+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett

libcli:auth: Return WERROR for encode_wkssvc_join_password_buffer()

2019-07-26T01:48:24+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett

s3:rpc_client: Return NTSTATUS for init_samr_CryptPasswordEx()

2019-07-26T01:48:22+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett

s3:rpc_client: Return NTSTATUS for init_samr_CryptPassword()

2019-07-26T01:48:22+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett

s3/lib/netapi: Fix 'Possible null pointer dereference' warning

2019-05-29T10:10:23+00:00

source3/lib/netapi/localgroup.c:1103: warning: nullPointer: Possible null pointer dereference: r <--[cppcheck]

Signed-off-by: Noel Power 
Reviewed-by: Andreas Schneider

s3:netapi: Use C99 initializer for poptOption in netapi example

2019-01-28T09:29:16+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Douglas Bagnall