samba.git/source3/lib/sharesec.c, branch talloc-2.4.4

s3:lib: Make sure struct security_ace is fully initialized

2024-06-24T06:14:35+00:00

Found by Covscan.

"Error: UNINIT (CWE-457):
samba-4.20.0rc2/source3/lib/sharesec.c:275: var_decl: Declaring variable ""ace"" without initializer.
samba-4.20.0rc2/source3/lib/sharesec.c:285: uninit_use_in_call: Using uninitialized value ""ace"". Field ""ace.object"" is uninitialized when calling ""make_sec_acl"".
  283|   	init_sec_ace(&ace, &global_sid_World, SEC_ACE_TYPE_ACCESS_ALLOWED, sa, 0);
  284|
  285|-> 	if ((psa = make_sec_acl(ctx, NT4_ACL_REVISION, 1, &ace)) != NULL) {
  286|   		psd = make_sec_desc(ctx, SECURITY_DESCRIPTOR_REVISION_1,
  287|   				    SEC_DESC_SELF_RELATIVE, NULL, NULL, NULL,"

Signed-off-by: Andreas Schneider 
Reviewed-by: Signed-off-by: Martin Schwenke

s3:lib: Remove trailing spaces in sharesec.c

2024-06-24T06:14:35+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Signed-off-by: Martin Schwenke

lib: Make get_share_security_default static

2020-09-12T06:29:37+00:00

Reviewed-by: Christof Schmitt 
Reviewed-by: Volker Lendecke

sharesec: Return NTSTATUS from delete_share_security

2019-11-26T21:28:31+00:00

Signed-off-by: Christof Schmitt 
Reviewed-by: Jeremy Allison

sharesec: Return NTSTATUS from set_share_security

2019-11-26T21:28:31+00:00

Signed-off-by: Christof Schmitt 
Reviewed-by: Jeremy Allison

sharesec: Return NTSTATUS from share_info_db_init

2019-11-26T21:28:31+00:00

Signed-off-by: Christof Schmitt 
Reviewed-by: Jeremy Allison

lib: Pass mem_ctx to state_path()

2018-08-17T09:30:11+00:00

Fix a confusing API: Many places TALLOC_FREE the path where it's not
clear you have to do it.

Signed-off-by: Volker Lendecke 
Reviewed-by: Andreas Schneider

sharesec: Remove error message for unmarshall_sec_desc failure

2015-07-06T18:19:12+00:00

In a cluster setup, running sharesec -D results in an empty record that
triggers this message. The situation is correctly handled in the code
(unmarshall_sec_desc fails and sharesec uses the default), so simply
remove the message in this case.

Signed-off-by: Christof Schmitt 
Reviewed-by: Jeremy Allison

Convert the few instances of int32 there were to int32_t.

2015-05-16T01:09:12+00:00

Signed-off-by: Richard Sharpe 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Sat May 16 03:09:12 CEST 2015 on sn-devel-104

Change all uses of uint32/16/8 in proto.h to uint32_t/16_t/8_t.

2015-04-29T21:42:20+00:00

Signed-off-by: Richard Sharpe 
Reviewed-by: Jeremy Allison