samba.git/source3/lib/system.c, branch talloc-2.3.4

smbd: remove itime and file_id logic and code

2022-03-31T23:01:37+00:00

This bases File-Ids on the inode numbers again. The whole stuff was
added because at that time Apple clients

1. would be upset by inode number reusage and

2. had a client side bug in their fallback implemetentation that
assigns File-Ids on the client side in case the server provides
File-Ids of 0.

After discussion with folks at Apple it should be safe these days to
rely on the Mac to generate its own File-Ids and let Samba return 0
File-Ids.

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

s3: includes: Make the comments describing itime consistent. Always use "invented" time.

2022-01-10T18:42:02+00:00

It gets confusing if we call it "imaginary" or "instantiation"
in different places.

Signed-off-by: Jones Syue 
Reviewed-by: Jeremy Allison 
Reviewed-by: Ralph Boehme 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Mon Jan 10 18:42:02 UTC 2022 on sn-devel-184

s3: lib: In create_clock_itime(), use timespec_current() -> clock_gettime(CLOCK_REALTIME..).

2022-01-10T17:49:27+00:00

CLOCK_MONOTONIC (which we previously used) is reset
when the system is rebooted.

CLOCK_REALTIME is a "wall clock" time. It's still affected by NTP
changes (for Linux we should probably use CLOCK_TAI instead
but that is Linux-specific). For most systems CLOCK_REALTIME
will be good enough.

Signed-off-by: Jeremy Allison 
Reviewed-by: Ralph Boehme

s3: smbd: Create and use a common function for generating a fileid - create_clock_itime().

2022-01-08T06:35:22+00:00

This first gets the clock_gettime_mono() value, converts to an NTTIME (as
this is what is stored in the dos attribute EA), then mixes in 8 bits of
randomness shifted up by 55 bits to cope with poor resolution clocks to
avoid duplicate inodes.

Using 8 bits of randomness on top of an NTTIME gives us around 114
years headroom. We can now guarentee returning a itime-based
fileid in a normal share (storing dos attributes in an EA).

Remove knownfail.d/fileid-unique

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14928

Signed-off-by: Jeremy Allison 
Reviewed-by: Christof Schmitt 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Sat Jan  8 06:35:22 UTC 2022 on sn-devel-184

system: Remove kernel_flock

2021-09-14T23:14:36+00:00

LOCK_MAND will be deprecated in the Linux kernel, so stop using this
feature and remove the kernel_flock function.

Signed-off-by: Christof Schmitt 
Reviewed-by: Jeremy Allison

Don't use sysconf(_SC_NGROUPS_MAX) on macOS for getgroups()

2021-09-09T17:43:19+00:00

On MacOS sysconf(_SC_NGROUPS_MAX) always returns 16. However, this is not
the value used by getgroups(2). MacOS uses nested groups but getgroups(2)
will return the flattened list which can easily exceed 16 groups. In my
testing getgroups() already returns 16 groups on a freshly installed
system. And on a 10.14 system the root user is in more than 16 groups by
default which makes it impossible to run smbd without this change.
Setting _DARWIN_UNLIMITED_GETGROUPS allows getgroups() to return more than
16 groups. This also changes set_unix_security_ctx() to only set up to
16 groups since that is the limit for initgroups() according to the manpage.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=8773

Signed-off-by: Alex Richardson 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Thu Sep  9 17:43:19 UTC 2021 on sn-devel-184

s3: lib: Add sys_fstatat() wrapper.

2021-07-14T08:09:31+00:00

Does the usual things we need with fake_dir_create_times.

Signed-off-by: Jeremy Allison 
Reviewed-by: Ralph Boehme

s3 lib system: Change signature of sys_proc_fd_path

2021-02-09T04:16:43+00:00

It's always called with sizeof(buf)

Signed-off-by: Gary Lockyer 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Tue Feb  9 04:16:43 UTC 2021 on sn-devel-184

s3 lib system: Fix clang compilation error

2021-02-09T03:09:34+00:00

Fix clang compilation error:
   error: format string is not a string literal [-Werror,-Wformat-nonliteral]

Signed-off-by: Gary Lockyer 
Reviewed-by: Jeremy Allison

s3/lib: add proc fds infrastructure

2020-12-16T09:08:30+00:00

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison