samba.git/source3/lib/system.c, branch talloc-2.4.2

source3/lib: Properly log the change in capability

2024-01-20T18:43:10+00:00

We used to log the following message for both adding and dropping
capability:

DBG_INFO("added capability %d\n", capability);

For better clarity indicate the change as "added" or "dropped"
based on available functional arguments.

Signed-off-by: Anoop C S 
Reviewed-by: Christof Schmitt 

Autobuild-User(master): Anoop C S 
Autobuild-Date(master): Sat Jan 20 18:43:10 UTC 2024 on atb-devel-224

system.c: fix fake directory create times

2024-01-16T14:37:31+00:00

This was broken by c9c3d4312d7281904fc back in 2009 already.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12421

Signed-off-by: Bjoern Jacke 
Reviewed-by: Volker Lendecke

set_process_capability: log which capability was set or failed to be set

2024-01-05T00:40:49+00:00

Signed-off-by: Bjoern Jacke 
Reviewed-by: Volker Lendecke

system.c: fall back to become_root if CAP_DAC_OVERRIDE isn't usable

2023-11-16T21:38:37+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15093

Signed-off-by: Bjoern Jacke 
Reviewed-by: Christof Schmitt

smbd: Simplify sys_proc_fd_path()

2023-11-01T18:55:32+00:00

We know the buffer size up-front, create a struct for that. Also, I
think if we ever hit another /proc pattern this is very likely on a
different OS that could be handled by an #ifdef.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

s3:lib: Fix code spelling

2023-07-13T05:41:36+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Martin Schwenke

smbd: remove itime and file_id logic and code

2022-03-31T23:01:37+00:00

This bases File-Ids on the inode numbers again. The whole stuff was
added because at that time Apple clients

1. would be upset by inode number reusage and

2. had a client side bug in their fallback implemetentation that
assigns File-Ids on the client side in case the server provides
File-Ids of 0.

After discussion with folks at Apple it should be safe these days to
rely on the Mac to generate its own File-Ids and let Samba return 0
File-Ids.

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

s3: includes: Make the comments describing itime consistent. Always use "invented" time.

2022-01-10T18:42:02+00:00

It gets confusing if we call it "imaginary" or "instantiation"
in different places.

Signed-off-by: Jones Syue 
Reviewed-by: Jeremy Allison 
Reviewed-by: Ralph Boehme 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Mon Jan 10 18:42:02 UTC 2022 on sn-devel-184

s3: lib: In create_clock_itime(), use timespec_current() -> clock_gettime(CLOCK_REALTIME..).

2022-01-10T17:49:27+00:00

CLOCK_MONOTONIC (which we previously used) is reset
when the system is rebooted.

CLOCK_REALTIME is a "wall clock" time. It's still affected by NTP
changes (for Linux we should probably use CLOCK_TAI instead
but that is Linux-specific). For most systems CLOCK_REALTIME
will be good enough.

Signed-off-by: Jeremy Allison 
Reviewed-by: Ralph Boehme

s3: smbd: Create and use a common function for generating a fileid - create_clock_itime().

2022-01-08T06:35:22+00:00

This first gets the clock_gettime_mono() value, converts to an NTTIME (as
this is what is stored in the dos attribute EA), then mixes in 8 bits of
randomness shifted up by 55 bits to cope with poor resolution clocks to
avoid duplicate inodes.

Using 8 bits of randomness on top of an NTTIME gives us around 114
years headroom. We can now guarentee returning a itime-based
fileid in a normal share (storing dos attributes in an EA).

Remove knownfail.d/fileid-unique

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14928

Signed-off-by: Jeremy Allison 
Reviewed-by: Christof Schmitt 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Sat Jan  8 06:35:22 UTC 2022 on sn-devel-184