samba.git/source3/lib/util_tdb.c, branch talloc-2.3.0

s3/lib: don't write to buffer (which might be NULL) if bufsize <=0

2019-05-29T10:10:23+00:00

Some code depends that tdb_pack[va] will return the bytes it would
write to 'buf' if the bufsize passed in is <=0, writing to the
buffer is protected by with lines like
   if (bufsize && bufsize >= len) {
      /* write to 'buf' */
   }

however in these instances the local pointer to the buffer is still
modified
   buf += len;

It's quite probable if bufsize == 0 that buf itself is NULL,
in this case we should protect against performing pointer arithmetic.

Signed-off-by: Noel Power 
Reviewed-by: Andreas Schneider

s3:lib: Fix undefined behavior in tdb_unpack()

2018-12-03T23:23:02+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Gary Lockyer 

Autobuild-User(master): Gary Lockyer 
Autobuild-Date(master): Tue Dec  4 00:23:03 CET 2018 on sn-devel-144

s3:lib: Fix undefined behavior in tdb_pack()

2018-12-03T20:16:31+00:00

util_tdb.c:98:5: runtime error: null pointer passed as argument 2, which
is declared to never be null

This means the second argument of memcpy() can't be NULL.

Signed-off-by: Andreas Schneider 
Reviewed-by: Gary Lockyer

s3:lib: Fix uninitialized variable

2018-12-03T20:16:31+00:00

util_tdb.c:116:7: error: ‘len’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
   buf += len;
       ^~
../../source3/lib/util_tdb.c:44:6: note: ‘len’ was declared here
  int len;
      ^~~

Signed-off-by: Andreas Schneider 
Reviewed-by: Gary Lockyer

lib: Remove unused tdb_trans_* functions

2018-10-27T19:24:24+00:00

The transactions have all moved to dbwrap

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

tdb_unpack: Protect against overflow

2018-10-08T20:17:09+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

tdb_unpack: Correct "len" arg for "B" format

2018-10-08T20:17:09+00:00

All but one of the users of the "B" format specifier passed in a pointer
to uint32_t instead of what tdb_unpack expected, an "int". Because this
is a purely internal API, change the tdb_unpack function and adjust that
one caller.

To reviewers: Please check carefully, thanks :-)

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

tdb_unpack: Convert to size_t for internal calculations

2018-10-08T20:17:09+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

lib: Remove unused tdb_pack_append()

2018-10-02T23:07:15+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

s3-lib: Fix format-nonliteral warning

2016-08-23T23:33:50+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12168

Signed-off-by: Amitay Isaacs 
Reviewed-by: Andreas Schneider 
Reviewed-by: Jeremy Allison