samba.git/source3/lib/version.c, branch talloc-2.3.3

s3: make better use of ccache by not including version.h in every C-file.

2009-01-15T21:56:01+00:00

version.h changes rather frequently. Since it is included via includes.h,
this means each C file will be a cache miss. This applies to the following
situations:

* When building a new package with a new Samba version

* building in a git branch after calling mkversion.sh
  after a new commit (i.e. virtually always)

This patch improves the situation in the following way:

* remove inlude "version.h" from includes.h

* Use samba_version_string() instead of SAMBA_VERSION_STRING
  in files that use no other macro from version.h instead of
  SAMBA_VERSION_STRING.

* explicitly include "version.h" in those files that use more
  macros from "version.h" than just SAMBA_VERSION_STRING.

Michael

Reorder defines for version for consistency with Samba 4.

2008-09-12T10:38:54+00:00

(This used to be commit fe36d83508a6b1a8de5ad58ec1d0c80cda7b4a21)

Simplify samba_version_string.

2008-07-17T12:16:19+00:00

This adds a new macro for a vender version function which will be returned
by the samba_version_string() function if defined.

Signed-off-by: Andreas Schneider 
Signed-off-by: Stefan Metzmacher 
(This used to be commit 8b9301fbc73f28c657ec81c605760a0ff7a1973a)

Move samba_extended_info_version to smbd/trans2.c

2008-01-22T12:00:22+00:00

This is right now only used there, and in version.c it gave linker errors
because some binaries (e.g. smbmnt) don't link in time.o
(This used to be commit 1f0eaaa5911f893c822465a26fe49ab65afb0730)

Avoid use of uninitialized memory

2008-01-22T11:46:51+00:00

(This used to be commit 85123aacdb13e97c3f44aeded1c80e13af53d83d)

Get Samba version or capability information from Windows

2008-01-22T11:39:47+00:00

On Jan 21 16:18, Danilo Almeida wrote:
> Corina wrote:
>
> > +	time_t samba_gitcommitdate;
>
> And:
>
> > +   SIVAL(pdata,28,extended_info.samba_gitcommitdate);
> > +   memcpy(pdata+32,extended_info.samba_version_string,32);
>
> Note that you are dropping bits on a system w/64-bit time_t, and that this has the 2038 problem.

Right.  I changed samba_gitcommitdate from time_t to NTTIME and shortened
samba_version_string to 28 bytes.  New patch below.

Thanks,
Corinna
(This used to be commit 28aa1c199d3a22cda34afcaab49c0561eeb0abcb)

Use SAFE_FREE instead of free

2008-01-19T18:31:02+00:00

(This used to be commit 999647329028147d7c29a3348202641b3e03430e)

Tiny memory leak in lib/version.c

2008-01-19T18:30:16+00:00

Hi,

while implementing the extra_info version stuff, it occured to me that
samba_version_string() potentially allocates memory which is unused but
never free'd.

If SAMBA_VERSION_VENDOR_PATCH is defined, a second call to asprintf
takes place.  The result is stored in tmp_version.  Afterwards,
samba_version is set to tmp_version without free'ing samba_version
first.  Looks like a simple free(samba_version) is missing.  Patch
against 3.2-test below.

Ok, this only happens once over the lifetime of the application, so it's
no big deal, but I though it doesn't hurt to mention it.

Corinna

	* lib/version.c (samba_version_string): Free samba_version
	before setting to tmp_version.
(This used to be commit 373a23d48f2dd24e65dbf814ea58b4add2322128)

Remove a static fstring

2007-12-16T13:02:26+00:00

(This used to be commit a9c62c57db9e580640d0265b08b3178496de76a8)

Correct VERSION and version.c to use SAMBA_VERSION_VENDOR_PATCH

2007-10-21T17:32:06+00:00

which is used by mkversion.sh.
(This used to be commit a62c7f9350322ab435244eafe6053fd5ee618973)