samba.git/source3/lib, branch talloc-2.2.0

lib: Remove "struct sid_parse_ret" again

2019-03-12T00:42:19+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Andrew Bartlett

lib: Make sid_parse return the parsed length

2019-03-12T00:42:19+00:00

Use a temporary struct as a return value to make the compiler catch all
callers. If we just changed bool->ssize_t, this would just generate a
warning. struct sid_parse_ret will go away in the next commit

Signed-off-by: Volker Lendecke 
Reviewed-by: Andrew Bartlett

lib/winbind_util: Add winbind_xid_to_sid for --without-winbind

2019-03-06T01:53:16+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13813

Signed-off-by: Christof Schmitt 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Wed Mar  6 01:53:16 UTC 2019 on sn-devel-144

lib/winbind_util: Remove winbind_[gu]id_to_sid

2019-03-06T00:50:15+00:00

Commit c906153cc7 removed these functions, now also remove them for the
--without-winbind case.

Signed-off-by: Christof Schmitt 
Reviewed-by: Jeremy Allison

lib/winbind_util: Move include out of ifdef

2019-03-06T00:50:14+00:00

This fixes compile errors about missing prototypes with
--picky-developer and --without-winbind

Signed-off-by: Christof Schmitt 
Reviewed-by: Jeremy Allison

lib: Use wrapper for string to integer conversion

2019-03-01T00:32:10+00:00

In order to detect an value overflow error during
the string to integer conversion with strtoul/strtoull,
the errno variable must be set to zero before the execution and
checked after the conversion is performed. This is achieved by
using the wrapper function strtoul_err and strtoull_err.

Signed-off-by: Swen Schillig 
Reviewed-by: Ralph Böhme 
Reviewed-by: Jeremy Allison

lib: Remove some unused code

2019-02-28T13:53:40+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Christof Schmitt 

Autobuild-User(master): Volker Lendecke 
Autobuild-Date(master): Thu Feb 28 13:53:41 UTC 2019 on sn-devel-144

lib: Introduce winbind_xid_to_sid

2019-02-28T12:57:24+00:00

This does not merge a winbind communication error into
"global_sid_NULL" (S-1-0-0), which by the way non-intuitively does not
go along with is_null_sid(). Instead, this just touches the output sid
when winbind returned success. This success might well be a negative
mapping indicated by S-0-0, which *is* is_null_sid()...

Signed-off-by: Volker Lendecke 
Reviewed-by: Christof Schmitt 
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13813

idmap_cache: Introduce idmap_cache_find_xid2sid

2019-02-28T12:57:24+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Christof Schmitt 
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13813

idmap_cache: Only touch "sid" on success in find_xid_to_sid

2019-02-28T12:57:23+00:00

Why? This makes the negative mapping condition (is_null_sid) more
explicit in the code.

The callers in lookup_sid initialized "psid" anyway before, and the ones
in wb_xids2sids now do as well. This is more in line with other APIs we
have: Only touch output parameters if you have something to say.

Signed-off-by: Volker Lendecke 
Reviewed-by: Christof Schmitt 
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13813