samba.git/source3/libads/ldap_utils.c, branch talloc-2.4.2

s3:libads: Allocate ADS_STRUCT under a talloc context

2022-06-27T15:50:30+00:00

The ads_destroy() function is now static and only called from the
ADS_STRUCT destructor.

Signed-off-by: Samuel Cabrero 
Reviewed-by: Jeremy Allison

s3/libads: clang: Fix 'Value stored during initialization is never read'

2019-09-26T18:41:27+00:00

Fixes:

source3/libads/ldap_utils.c:52:13: warning: Value stored to 'status' during its initialization is never read <--[clang]
        ADS_STATUS status = ADS_SUCCESS;
                   ^~~~~~   ~~~~~~~~~~~
1 warning generated.

Signed-off-by: Noel Power 
Reviewed-by: Jeremy Allison

s3: ldap: Ensure the ADS_STRUCT pointer doesn't get freed on error, we don't own it here.

2018-01-26T01:25:20+00:00

Thanks to Isaac Boukris  for finding the
issue and testing this fix.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13244

Signed-off-by: Jeremy Allison 
Reviewed-by: Volker Lendecke 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Fri Jan 26 02:25:20 CET 2018 on sn-devel-144

s3-libads: Use the configured LDAP page size.

2016-01-15T02:59:16+00:00

We already allow the user to configure LDAP page size, and use it in pdb_ldap.
But then we hard-code the initial LDAP page size value to 1000 in ads_init, so
it doesn't take effect there.  So let's use the configured LDAP page size value
in ads_init also, which defaults to 1000.

Signed-off-by: Justin Maggard 
Reviewed-by: Jeremy Allison 
Reviewed-by: Volker Lendecke 

Autobuild-User(master): Volker Lendecke 
Autobuild-Date(master): Fri Jan 15 03:59:16 CET 2016 on sn-devel-144

lib: Make sid_binstring_hex use TALLOC

2015-05-12T23:44:20+00:00

talloc_tos() is better than plain malloc...

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

Convert all uses of uint8/16/32 to uint8/16/32_t in the libads code.

2015-04-22T04:22:29+00:00

Signed-off-by: Richard Sharpe 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Wed Apr 22 06:22:29 CEST 2015 on sn-devel-104

lib/param: Move all enum declarations to lib/param

2012-07-24T09:01:17+00:00

This is in preperation for the parameter table being made common.

Andrew Bartlett

Pair-Programmed-With: Andrew Tridgell

s3-libads: Use a reducing page size to try and cope with a slow LDAP server

2012-05-26T00:03:08+00:00

If we cannot get 1000 users downloaded in 15seconds, try with 500, 250
and then 125 users at a time.

Andrew Bartlett

Signed-off-by: Jeremy Allison

s3-talloc Change TALLOC_ARRAY() to talloc_array()

2011-06-09T10:40:08+00:00

Using the standard macro makes it easier to move code into common, as
TALLOC_ARRAY isn't standard talloc.

s3: Make ads_ranged_search_internal static

2010-11-20T13:42:44+00:00