samba.git/source3/libads, branch talloc-2.4.2

s3:libads: Fix memory leaks in ads_create_machine_acct()

2024-01-23T13:23:33+00:00

Indirect leak of 291 byte(s) in 2 object(s) allocated from:
    #0 0x7fd77b6dc03f in malloc (/lib64/libasan.so.8+0xdc03f) (BuildId: 3e1694ad218c99a8b1b69231666a27df63cf19d0)
    #1 0x7fd77b094bc2 in __talloc_with_prefix ../../lib/talloc/talloc.c:783
    #2 0x7fd77b096034 in __talloc ../../lib/talloc/talloc.c:825
    #3 0x7fd77b096034 in __talloc_strlendup ../../lib/talloc/talloc.c:2454
    #4 0x7fd77b096034 in talloc_strdup ../../lib/talloc/talloc.c:2470
    #5 0x7fd779996633 in add_string_to_array ../../lib/util/util_strlist.c:504
    #6 0x7fd77b10c754 in ads_create_machine_acct ../../source3/libads/ldap.c:2662
    #7 0x7fd77b46705f in libnet_join_precreate_machine_acct ../../source3/libnet/libnet_join.c:390
    #8 0x7fd77b46705f in libnet_DomainJoin ../../source3/libnet/libnet_join.c:2852
    #9 0x7fd77b46705f in libnet_Join ../../source3/libnet/libnet_join.c:3036
    #10 0x55fb9788d91a in net_ads_join ../../source3/utils/net_ads.c:1853
    #11 0x55fb9793ab86 in net_join ../../source3/utils/net_join.c:45
    #12 0x55fb9793084f in net_run_function ../../source3/utils/net_util.c:454
    #13 0x55fb97889859 in main ../../source3/utils/net.c:1372
    #14 0x7fd7768281af in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58

Signed-off-by: Andreas Schneider 
Reviewed-by: Volker Lendecke

s3:libads: Fix code spelling

2023-10-25T22:23:37+00:00

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

s3:libads: Update code reference in comment

2023-10-25T22:23:37+00:00

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

s3:libads: Improve logging for failover scenarios

2023-10-18T15:47:09+00:00

Signed-off-by: Pavel Filipenský 
Reviewed-by: Andreas Schneider 

Autobuild-User(master): Pavel Filipensky 
Autobuild-Date(master): Wed Oct 18 15:47:09 UTC 2023 on atb-devel-224

Revert "s3:libads: Don’t do first loop iteration if ‘attr’ is NULL"

2023-10-13T02:18:31+00:00

Fixes CID 1547073: Control flow issues (DEADCODE).

This reverts commit 184a48d65772f359bd81f83256daada8c9e500b3.

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

s3:libads: Fix building with FORTIFY_SOURCE=2

2023-10-01T22:45:38+00:00

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

s3:libads: Don’t do first loop iteration if ‘attr’ is NULL

2023-10-01T22:45:38+00:00

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

libsmb: Make libsmb/clispnego.c static to libads/

2023-09-25T19:01:34+00:00

It's only called there. The "+" part of this patch might not conform
to README.Coding because it's a literal cut&paste.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

s3:libads: Fix code spelling

2023-09-11T02:42:41+00:00

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

s3:libads: Add missing newlines to logging messages

2023-08-08T04:39:38+00:00

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett