samba.git/source3/libads, branch talloc-2.4.4

libads: change netlogon_pings() behaviour wrt to min_servers parameter

2025-08-13T19:31:10+00:00

Currently if a caller passes min_servers=X with X>1, netlogon_pings() will fail
if it can't contact X DCs. This is not really what we want. What we want is: we
want at least one DC, and up to X.

Change implemenentation in that sense and rename the min_servers argument to
wanted_servers to express this behaviour change.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15844

Signed-off-by: Ralph Boehme 
Reviewed-by: Guenther Deschner 

Autobuild-User(master): Günther Deschner 
Autobuild-Date(master): Wed Aug 13 19:31:10 UTC 2025 on atb-devel-224

libads: reverse termination condition in netlogon_pings_done()

2025-08-13T18:30:44+00:00

No change in behaviour, prepares for upcoming change and minimizes its diff.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15844

Signed-off-by: Ralph Boehme 
Reviewed-by: Guenther Deschner

libads: fix get_kdc_ip_string()

2025-08-13T18:30:44+00:00

Correctly handle the interaction between optionally passed in DC via
pss and DC lookup.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15876

Signed-off-by: Ralph Boehme 
Reviewed-by: Guenther Deschner

libads: check for if DCs are in paused state when processing CLDAP replies

2025-07-30T09:09:40+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14981

Signed-off-by: Ralph Boehme 
Reviewed-by: Guenther Deschner

s3/libads: get rid of additional loop calling add_failed_connection_entry()

2025-07-30T09:09:40+00:00

Just call add_failed_connection_entry() in the initial loop at all places where
we have a "bad" result.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14981

Signed-off-by: Ralph Boehme 
Reviewed-by: Guenther Deschner

s3:libads: let get_kdc_ip_string() check for a blacklisted server name

2025-07-30T09:09:40+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14981

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Ralph Boehme 
Reviewed-by: Guenther Deschner

s3:libads: let cldap_ping_list() check for a blacklisted server name

2025-07-30T09:09:40+00:00

If we black listed a server we should not use it even if
it responses to CLDAP requests.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14981

Pair-Programmed-With: Ralph Boehme 
Signed-off-by: Ralph Boehme 
Reviewed-by: Guenther Deschner

libads: fix get_kdc_ip_string() ...

2025-07-07T16:46:29+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15881

Signed-off-by: Ralph Boehme 
Reviewed-by: Guenther Deschner 

Autobuild-User(master): Günther Deschner 
Autobuild-Date(master): Mon Jul  7 16:46:29 UTC 2025 on atb-devel-224

libsmb: Remove "source3/libsmb/libsmb.h"

2025-06-16T15:05:32+00:00

libsmb.h added ads_status.h and cli_smb2_fnum.h. Only few users need
either.

Signed-off-by: Volker Lendecke 
Reviewed-by: Ralph Boehme

s3:net: 'net ads keytab list' should only list default keytab

2025-04-11T07:35:49+00:00

If you don't specify a keytab, assume we just want the default keytab. This will
make upcoming changes to the code easier.

Signed-off-by: Andreas Schneider 
Reviewed-by: Pavel Filipenský