samba.git/source3/libsmb, branch master

s3/libsmb: Use PULL_LE_U64 for BIG_UINT

2026-03-01T10:15:29+00:00

Signed-off-by: Anoop C S 
Reviewed-by: Martin Schwenke

s3/libsmb: Convert build_fs_quota_buffer() to use PUSH_LE_U64

2026-03-01T10:15:29+00:00

Signed-off-by: Anoop C S 
Reviewed-by: Martin Schwenke

s3/libsmb: block anon authentication fallback is use-kerberos = desired

2026-02-17T16:06:18+00:00

When cli_credentials_get_kerberos_state returns CRED_USE_KERBEROS_REQUIRED
libsmbclient method SMBC_server_internal will still try to fallback to
anon NTLM. This patch prevents that.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=15789
Signed-off-by: Noel Power 
Reviewed-by: Andreas Schneider 

Autobuild-User(master): Noel Power 
Autobuild-Date(master): Tue Feb 17 16:06:18 UTC 2026 on atb-devel-224

s3/libsmb: cli_session_creds_init fails when kerberos is desired

2026-02-17T15:03:39+00:00

There is a regression with code using cli_session_creds_init when
cli_credentials_get_kerberos_state() returns CRED_USE_KERBEROS_DESIRED

Authentication succeeds when boolean fallback_after_kerberos is false
and fails when true.
There doesn't seem to be a good reason why the value of
fallback_after_kerberos should initialise the krb5 ccache or not.
It would seems that krb5 cache should be setup for creds
for *any* kerberos auth (whether fallback is enabled or not)

Partial patch from  (see bug referenced below)
Bug: https://bugzilla.samba.org/show_bug.cgi?id=15789
Signed-off-by: Noel Power 
Reviewed-by: Andreas Schneider

s3:libads: Separate use of ads->config.flags for NBT_* and DS_* values

2026-01-22T09:14:25+00:00

Use of ads->config.flags is overloaded.

It is used to:

- pass DS_* flags down to cldap_netlogon()
- store the server_type from NETLOGON_SAM_LOGON_RESPONSE

Both cases use different values and cannot be combined.
E.g. flags mess up with value 0x00000080

NBT_SERVER_CLOSEST  0x00000080
DS_PDC_REQUIRED     0x00000080

Let's create two separate flags

nbt_server_type server_flags; /* NBT_* cldap flags identifying the services. */
uint32 required_flags; /* DS_* - Netlogon flags */

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15972

Signed-off-by: Pavel Filipenský 
Reviewed-by: Andreas Schneider 

Autobuild-User(master): Pavel Filipensky 
Autobuild-Date(master): Thu Jan 22 09:14:25 UTC 2026 on atb-devel-224

s3:libsmb: Rework check_negative_conn_cache()

2026-01-13T17:00:06+00:00

The name and results are confusing. Rename the function and use a bool that it
is easier to understand.

Signed-off-by: Andreas Schneider 
Reviewed-by: Pavel Filipenský 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Tue Jan 13 17:00:06 UTC 2026 on atb-devel-224

s3:lib/util_sock: allow {before,after}_connect hooks to be passed to open_socket_out_send()

2026-01-13T08:13:04+00:00

async_connect_send() already has these hooks now open_socket_out_send()
callers can pass them through.

This will be useful for IPPROTO_SMBDIRECT sockets to setup things
between the socket() and connect() syscalls.

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Volker Lendecke 

Autobuild-User(master): Volker Lendecke 
Autobuild-Date(master): Tue Jan 13 08:13:04 UTC 2026 on atb-devel-224

s3:libsmb: Call the correct function in smbc_fgetxattr()

2025-12-09T18:30:34+00:00

Looks like nobody ever tested this.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15960

Signed-off-by: Andreas Schneider 
Reviewed-by: Ralph Boehme

libsmbclient: Fix negotiating posix_extensions

2025-12-09T18:30:34+00:00

Without this, smbc_setOptionPosixExtensions() does nothing.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15960

Signed-off-by: Andreas Schneider 
Reviewed-by: Ralph Boehme

s3: talloc_destroy() -> TALLOC_FREE()

2025-11-10T13:29:30+00:00

Sweeping change, I know. Should not change compiled code in most
cases, the compiler should be smart enough to elide the assignment
right before a return. In the cases where this is not right before the
return, TALLOC_FREE() is safer as it makes use-after-free crash.

Signed-off-by: Volker Lendecke 
Reviewed-by: Anoop C S